Skip to content

fix(mobile): forward image props to Expo Image#86

Draft
GSTJ wants to merge 2 commits into
mainfrom
GSTJ/fix-mobile-image-props
Draft

fix(mobile): forward image props to Expo Image#86
GSTJ wants to merge 2 commits into
mainfrom
GSTJ/fix-mobile-image-props

Conversation

@GSTJ

@GSTJ GSTJ commented Jul 13, 2026

Copy link
Copy Markdown
Owner

Summary

Image options and callbacks now reach the native image instead of being dropped on its layout wrapper.

Details

  • Render one Expo Image so current and future image props reach the component that owns them.
  • Use API blurhash values as placeholders while keeping caller-provided placeholders and cache policies intact.
  • Keep the existing memory-and-disk cache default and match the blurhash fit to the final image.

Testing steps

  1. Open the swipe screen and confirm the dog photo and reaction icons render with the expected crop and rounded corners.
  2. Open Messages, a chat, Profile, and Edit profile, then confirm every dog photo renders without clipping or flashing.
  3. Switch between light and dark mode and confirm the photos stay visible on the affected screens.

@GSTJ

GSTJ commented Jul 13, 2026

Copy link
Copy Markdown
Owner Author

Verification for e8f83ca:

  • corepack pnpm --version: 9.6.0
  • corepack pnpm --filter @pegada/mobile verify:image-props: passed
  • corepack pnpm --filter @pegada/mobile typecheck: passed
  • Scoped Oxlint, Oxfmt, and git diff --check: passed
  • Release iOS simulator build: passed
  • Simulator: 8C6F98B8-C89E-4FD8-91CC-2CA518E7F44C (isolated from the main test simulator)
  • Final app process: PID 11042, still alive after 1m05s
  • Light screenshot: /private/tmp/pegada-image-props-evidence/final/light/current.png
  • Dark screenshot: /private/tmp/pegada-image-props-evidence/final/dark/swipe-retry.png

The full workspace test command is still blocked before the test phase because Turbo does not pass DIRECT_URL to the API Prisma pretest. The mobile checks above are green, and that workspace issue is unchanged from main.

@GSTJ
GSTJ marked this pull request as ready for review July 22, 2026 13:26
@GSTJ
GSTJ marked this pull request as draft July 22, 2026 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant