DG: Add optional LR scheduler support via train_params#179
Open
dagarfield wants to merge 1 commit intomainfrom
Open
DG: Add optional LR scheduler support via train_params#179dagarfield wants to merge 1 commit intomainfrom
dagarfield wants to merge 1 commit intomainfrom
Conversation
Allow train_params['lr_scheduler'] to accept a dict specifying a scheduler type and its parameters. Supports reduce_on_plateau, step, and cosine schedulers. Defaults to None (no scheduler), preserving existing behavior. Co-authored-by: Ona <no-reply@ona.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
configure_optimizersnow supports an optional learning rate scheduler configured viatrain_params["lr_scheduler"]. When set to a dict, a scheduler is created and returned alongside the optimizer. WhenNone(the default), behavior is unchanged.Supported scheduler types:
"reduce_on_plateau"—ReduceLROnPlateauwithfactor,patience,monitor"step"—StepLRwithstep_size,gamma"cosine"—CosineAnnealingLRwithT_max(defaults tomax_epochs)Example usage:
Related Issue(s)
N/A
How to test
lr_schedulerintrain_params— verify behavior is identical to before.Verify the learning rate decays every 5 epochs by checking logged LR or optimizer state.
3. Pass an invalid
typeand verify the error message is raised.