Modify the projection formula, add tolerance, and add tests.#8870
Merged
joa-quim merged 1 commit intoGenericMappingTools:masterfrom Jan 23, 2026
Merged
Modify the projection formula, add tolerance, and add tests.#8870joa-quim merged 1 commit intoGenericMappingTools:masterfrom
joa-quim merged 1 commit intoGenericMappingTools:masterfrom
Conversation
joa-quim
approved these changes
Jan 22, 2026
Member
|
In Code Validator it says that there is an error with the script of this PR. |
Contributor
Author
ok,I'll change the execute permission. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When dip=90° and rank=180°, tan(90°)×sin(180°)=Inf×0, causing an error.
Change the formula in the utilmeca_proj_radius function from atan(tand×sind) to atan2(sin×sin, cos) and add an epsilon tolerance.
Fixes #8053
Test results:
