BREAKING: Raise GMTParameterError exception for at_least_one parameters. Previously raise GMTInvalidInput #4380
+48
−40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modified files for grdclip, grdfill, grdgradient,test_grdclip, test_grdfill, test_grdgradient
seisman
reviewed
Feb 1, 2026
seisman
reviewed
Feb 1, 2026
Member
|
Also need to update |
Co-authored-by: Dongdong Tian <[email protected]>
Co-authored-by: Dongdong Tian <[email protected]>
Co-authored-by: Dongdong Tian <[email protected]>
Co-authored-by: Dongdong Tian <[email protected]>
seisman
reviewed
Feb 1, 2026
Co-authored-by: Dongdong Tian <[email protected]>
Co-authored-by: Dongdong Tian <[email protected]>
Co-authored-by: Dongdong Tian <[email protected]>
seisman
reviewed
Feb 1, 2026
Co-authored-by: Dongdong Tian <[email protected]>
seisman
reviewed
Feb 1, 2026
| "Missing required parameters: " | ||
| f"{', '.join(repr(par) for par in at_least_one)}. " | ||
| "Must specify at least one." | ||
| ) |
Member
There was a problem hiding this comment.
So, the error message is like this:
Missing required parameters: 'par1', 'par2', 'par3'. Must specify at least one.
The first sentence reads like all the parameters are required, so it's a little confusing.
What about this one?
Missing parameter: requires at least one of 'par1', 'par2', 'par3'.
Contributor
Author
There was a problem hiding this comment.
Missing parameter: requires at least one of 'par1', 'par2', 'par3'.
It's more concise, I think it's good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add GMTParameterError:at_least_one
@seisman
This is the second PR of #4003
requiredmust_have,neededMissing required parameter: '{param}'Missing required parameters: '{a}', '{b}'at_least_oneneed_one_of, , ,any_of``one_of``required_anyMissing required parameters: '{a}', '{b}', '{c}'. Must specify at least one.Must specify at least one of the parameters: '{a}', '{b}', '{c}'exactly_onemutually_exclusiveMutually exclusive parameters: '{a}', '{b}', '{c}'. Specify exactly one.at_most_onemutually_exclusiveMutually exclusive parameters: '{a}', '{b}', '{c}'. Specify at most oneconflicts_withconflicts,incompatible_withConflicting parameters: '{a}' cannot be used with '{b}', '{c}'