Figure: Defer figure activation until plotting arguments are prepared#4756
Open
seisman wants to merge 1 commit into
Open
Figure: Defer figure activation until plotting arguments are prepared#4756seisman wants to merge 1 commit into
seisman wants to merge 1 commit into
Conversation
seisman
added
maintenance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move
self._activate_figure()later in plotting wrappers, immediately before the first GMT session call.This lets PyGMT perform pure-Python operations and validations before activating a figure or changing GMT state. Invalid input now fails earlier without creating or modifying the figure state.
Figure.hlinesandFigure.vlinesretain earlier activation because they may need to retrieve the current plot region before delegating toFigure.plot.