Cleanup verbose logging in kubelet monitor#1199
Open
courageJ wants to merge 1 commit into
Open
Conversation
courageJ
force-pushed
the
cleanup-verbose-logging
branch
from
b4eb41b to
d988a02
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description: Cleanup Verbose and Sensitive Logging in Kubelet Monitor
Summary
This PR refactors the error logging in the
kubeletpackage to improve log hygiene and readability.Previously, translation failures would result in printing large, complex internal data structures (such as the full
stats.Summaryobject). This led to significant log bloat and made it difficult for operators to parse actual error messages.Changes
fmt.Errorfcalls to ensure log messages remain concise and actionable.Verification Results
go test ./kubelet/...in themonitordirectory.ok github.com/GoogleCloudPlatform/k8s-stackdriver/kubelet-to-gcm/monitor/kubelet 0.029s