Enforce response body limits in kubelet-to-gcm#1201
Open
courageJ wants to merge 1 commit into
Open
Conversation
- Added io.LimitReader to response body reads in controller, kubelet, and config packages. - Prevents unbounded memory allocation from potentially large responses. - Switched from deprecated ioutil.ReadAll to io.ReadAll. - Added unit tests for size limiting and success cases.
courageJ
force-pushed
the
fix-response-body-limits
branch
from
9e09848 to
d0d9650
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements size limits when reading HTTP response bodies in the kubelet-to-gcm monitoring daemon to prevent potential unbounded memory allocation.
Key changes:
Tested locally with go test ./monitor/... in kubelet-to-gcm.