Add max_custom_on_demand_retention_days in Backup Plan

[Megha-Bose]

backupdr: added support for custom on-demand retention in creation and update of backup plans

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[c2thorn]

can we test updating this in https://github.com/GoogleCloudPlatform/magic-modules/blob/main/mmv1/third_party/terraform/services/backupdr/resource_backup_dr_backup_plan_test.go#L10 ?

[Megha-Bose]

can we test updating this in https://github.com/GoogleCloudPlatform/magic-modules/blob/main/mmv1/third_party/terraform/services/backupdr/resource_backup_dr_backup_plan_test.go#L10 ?

The test updates the value from 30 to 45. I have now added a comment too.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 56 insertions(+))
google-beta provider: Diff ( 6 files changed, 57 insertions(+))
terraform-google-conversion: Diff ( 4 files changed, 43 insertions(+))

Missing doc report (experimental)

The following data sources are missing documents:

• google_backup_dr_backup_plan, expect file /website/docs/d/backup_dr_backup_plan.html.markdown to exist.

[modular-magician]

Tests analytics

Total tests: 17
Passed tests: 11
Skipped tests: 2
Affected tests: 4

Click here to see the affected service packages

• backupdr

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccBackupDRBackupPlan_backupDrBackupPlanForDiskResourceExample
• TestAccBackupDRBackupPlan_backupDrBackupPlanSimpleExample
• TestAccBackupDRBackupPlan_fullUpdate
• TestAccDataSourceGoogleBackupDRBackupPlan_basic

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccBackupDRBackupPlan_backupDrBackupPlanForDiskResourceExample [Error message] [Debug log]
TestAccBackupDRBackupPlan_backupDrBackupPlanSimpleExample [Error message] [Debug log]
TestAccBackupDRBackupPlan_fullUpdate [Error message] [Debug log]
TestAccDataSourceGoogleBackupDRBackupPlan_basic [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test