Add instance_flexibility_policy to master & worker nodes #16038

sravani-bobbala · 2025-12-29T06:20:14Z

Release Note Template for Downstream PRs (will be copied)

dataproc: added `instance_flexibility_policy` to `master_config` and `worker_config` in `google_dataproc_cluster` resource.

uncommenting the subnet config

This change introduces the instance_flexibility_policy block to the master_config and worker_config sections of the google_dataproc_cluster resource, allowing users to specify a ranked list of machine types.

…adding missed file

github-actions · 2025-12-30T03:35:40Z

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

sravani-bobbala · 2025-12-30T05:07:03Z

Attaching local test results.
LocalTest.log

slevenick · 2025-12-30T17:17:20Z

mmv1/third_party/terraform/services/dataproc/resource_dataproc_cluster_test.go

+        boot_disk_size_gb = 35
+      }
+      instance_flexibility_policy {
+				instance_selection_list {


Can you modify a test to specify a rank = 2 instance selection before a rank 1 one? Often we see issues when a server reorders lists based on some criteria that Terraform doesn't know about, so it's good to test that case specifically!

modular-magician · 2025-12-30T17:29:44Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 454 insertions(+), 4 deletions(-))
google-beta provider: Diff ( 4 files changed, 454 insertions(+), 4 deletions(-))

Missing doc report (experimental)

The following resources have fields missing in documents.

google_dataproc_cluster
- Expected Document Path: /website/docs/r/dataproc_cluster.html.markdown
- Fields: [cluster_config.master_config.instance_flexibility_policy.instance_selection_list cluster_config.master_config.instance_flexibility_policy.instance_selection_list.machine_types cluster_config.master_config.instance_flexibility_policy.instance_selection_list.rank cluster_config.master_config.instance_flexibility_policy.instance_selection_results cluster_config.master_config.instance_flexibility_policy.instance_selection_results.machine_type cluster_config.master_config.instance_flexibility_policy.instance_selection_results.vm_count cluster_config.worker_config.instance_flexibility_policy.instance_selection_list cluster_config.worker_config.instance_flexibility_policy.instance_selection_list.machine_types cluster_config.worker_config.instance_flexibility_policy.instance_selection_list.rank cluster_config.worker_config.instance_flexibility_policy.instance_selection_results cluster_config.worker_config.instance_flexibility_policy.instance_selection_results.machine_type cluster_config.worker_config.instance_flexibility_policy.instance_selection_results.vm_count]

modular-magician · 2025-12-30T17:36:33Z

Tests analytics

Total tests: 81
Passed tests: 68
Skipped tests: 6
Affected tests: 7

Click here to see the affected service packages

dataproc

Action taken

Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDataprocCluster_allInstanceFlexibilityPolicy

TestAccDataprocCluster_masterInstanceFlexibilityPolicy

TestAccDataprocCluster_withAccelerators

TestAccDataprocCluster_withConfidentialCompute

TestAccDataprocCluster_withNodeGroupAffinity

TestAccDataprocCluster_withReservationAffinity

TestAccDataprocCluster_workerInstanceFlexibilityPolicy

Get to know how VCR tests work

modular-magician · 2025-12-30T17:46:39Z

🟢 Tests passed during RECORDING mode:
TestAccDataprocCluster_allInstanceFlexibilityPolicy [Debug log]
TestAccDataprocCluster_workerInstanceFlexibilityPolicy [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode:
TestAccDataprocCluster_masterInstanceFlexibilityPolicy [Error message] [Debug log]
TestAccDataprocCluster_withAccelerators [Error message] [Debug log]
TestAccDataprocCluster_withConfidentialCompute [Error message] [Debug log]
TestAccDataprocCluster_withNodeGroupAffinity [Error message] [Debug log]
TestAccDataprocCluster_withReservationAffinity [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

slevenick · 2026-01-02T18:45:41Z

/gcbrun

modular-magician · 2026-01-02T18:57:09Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 459 insertions(+), 4 deletions(-))
google-beta provider: Diff ( 4 files changed, 459 insertions(+), 4 deletions(-))

Missing doc report (experimental)

The following resources have fields missing in documents.

google_dataproc_cluster
- Expected Document Path: /website/docs/r/dataproc_cluster.html.markdown
- Fields: [cluster_config.master_config.instance_flexibility_policy.instance_selection_list cluster_config.master_config.instance_flexibility_policy.instance_selection_list.machine_types cluster_config.master_config.instance_flexibility_policy.instance_selection_list.rank cluster_config.master_config.instance_flexibility_policy.instance_selection_results cluster_config.master_config.instance_flexibility_policy.instance_selection_results.machine_type cluster_config.master_config.instance_flexibility_policy.instance_selection_results.vm_count cluster_config.worker_config.instance_flexibility_policy.instance_selection_list cluster_config.worker_config.instance_flexibility_policy.instance_selection_list.machine_types cluster_config.worker_config.instance_flexibility_policy.instance_selection_list.rank cluster_config.worker_config.instance_flexibility_policy.instance_selection_results cluster_config.worker_config.instance_flexibility_policy.instance_selection_results.machine_type cluster_config.worker_config.instance_flexibility_policy.instance_selection_results.vm_count]

modular-magician · 2026-01-02T19:03:22Z

Tests analytics

Total tests: 81
Passed tests: 72
Skipped tests: 6
Affected tests: 3

Click here to see the affected service packages

dataproc

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDataprocCluster_allInstanceFlexibilityPolicy

TestAccDataprocCluster_masterInstanceFlexibilityPolicy

TestAccDataprocCluster_workerInstanceFlexibilityPolicy

Get to know how VCR tests work

modular-magician · 2026-01-02T19:13:05Z

🟢 Tests passed during RECORDING mode:
TestAccDataprocCluster_allInstanceFlexibilityPolicy [Debug log]
TestAccDataprocCluster_workerInstanceFlexibilityPolicy [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode:
TestAccDataprocCluster_masterInstanceFlexibilityPolicy [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

slevenick

resource_dataproc_cluster_test.go:694: Step 1/1 error: Check failed: Check 1/2 error: Check 4/4 error: google_dataproc_cluster.master_instance_flexibility_policy: Attribute 'cluster_config.0.master_config.0.instance_flexibility_policy.0.instance_selection_results.0.machine_type' expected to be set

sravani-bobbala and others added 5 commits December 3, 2025 12:51

Add support for dataproc cluster idle_stop_ttl and auto_stop_time

374a6af

Update resource_dataproc_cluster_test.go

bf6a030

uncommenting the subnet config

Merge branch 'GoogleCloudPlatform:main' into main_flex

8878fbf

Add Instance Flexibility Policy support for master and worker nodes.

3802f42

This change introduces the instance_flexibility_policy block to the master_config and worker_config sections of the google_dataproc_cluster resource, allowing users to specify a ranked list of machine types.

Add Instance Flexibility Policy support for master and worker nodes. …

2c5b822

…adding missed file

modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Dec 29, 2025

sravani-bobbala marked this pull request as ready for review December 30, 2025 03:34

github-actions bot requested a review from slevenick December 30, 2025 03:35

slevenick reviewed Dec 30, 2025

View reviewed changes

modular-magician added service/dataproc and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Dec 30, 2025

Change Rank order and Fix the test failures

4122524

modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Dec 31, 2025

github-actions bot requested a review from slevenick December 31, 2025 16:05

modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jan 2, 2026

slevenick requested changes Jan 2, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add instance_flexibility_policy to master & worker nodes #16038

Add instance_flexibility_policy to master & worker nodes #16038

sravani-bobbala commented Dec 29, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Dec 30, 2025

Uh oh!

sravani-bobbala commented Dec 30, 2025

Uh oh!

slevenick Dec 30, 2025

Uh oh!

modular-magician commented Dec 30, 2025

Uh oh!

modular-magician commented Dec 30, 2025

Uh oh!

modular-magician commented Dec 30, 2025

Uh oh!

slevenick commented Jan 2, 2026

Uh oh!

modular-magician commented Jan 2, 2026

Uh oh!

modular-magician commented Jan 2, 2026

Uh oh!

modular-magician commented Jan 2, 2026

Uh oh!

slevenick left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Add instance_flexibility_policy to master & worker nodes #16038

Are you sure you want to change the base?

Add instance_flexibility_policy to master & worker nodes #16038

Conversation

sravani-bobbala commented Dec 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Dec 30, 2025

Uh oh!

sravani-bobbala commented Dec 30, 2025

Uh oh!

slevenick Dec 30, 2025

Choose a reason for hiding this comment

Uh oh!

modular-magician commented Dec 30, 2025

Diff report

Missing doc report (experimental)

Uh oh!

modular-magician commented Dec 30, 2025

Tests analytics

Action taken

Uh oh!

modular-magician commented Dec 30, 2025

Uh oh!

slevenick commented Jan 2, 2026

Uh oh!

modular-magician commented Jan 2, 2026

Diff report

Missing doc report (experimental)

Uh oh!

modular-magician commented Jan 2, 2026

Tests analytics

Action taken

Uh oh!

modular-magician commented Jan 2, 2026

Uh oh!

slevenick left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

sravani-bobbala commented Dec 29, 2025 •

edited

Loading