-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Changes for adding region parameter for multiregion Point In time res… #16039
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes for adding region parameter for multiregion Point In time res… #16039
Conversation
|
Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: For automatic test runs see go/terraform-auto-test-runs. @zli82016, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Errors
|
Non-exercised tests🔴 Tests were added that are skipped in VCR:
Tests analyticsTotal tests: 0 Click here to see the affected service packages
🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR. View the build log |
zli82016
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
google-beta/services/sql/resource_sql_database_instance.go:3431:3: unknown field Region in struct literal of type sqladmin.PointInTimeRestoreContext
mmv1/third_party/terraform/services/sql/resource_sql_database_instance_test.go.tmpl
Outdated
Show resolved
Hide resolved
mmv1/third_party/terraform/services/sql/resource_sql_database_instance_test.go.tmpl
Outdated
Show resolved
Hide resolved
mmv1/third_party/terraform/services/sql/resource_sql_database_instance_test.go.tmpl
Show resolved
Hide resolved
mmv1/third_party/terraform/services/sql/resource_sql_database_instance_test.go.tmpl
Show resolved
Hide resolved
This is because cl/846845835 marks the region field as GOOGLE_INTERNAL, so the required clients are not generated. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Errors
|
Non-exercised tests🔴 Tests were added that are skipped in VCR:
Tests analyticsTotal tests: 0 Click here to see the affected service packages
🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR. View the build log |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Errors
|
Non-exercised tests🔴 Tests were added that are skipped in VCR:
Tests analyticsTotal tests: 0 Click here to see the affected service packages
🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR. View the build log |
|
@zli82016 This PR has been waiting for review for 3 weekdays. Please take a look! Use the label |
Uh oh!
There was an error while loading. Please reload this page.