Skip to content

Conversation

@aditikumarii-google
Copy link
Contributor

@aditikumarii-google aditikumarii-google commented Dec 29, 2025

sql: added `point_in_time_restore_context.region` field to `google_sql_database_instance` resource 

@github-actions
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@zli82016, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 185 insertions(+))
google-beta provider: Diff ( 3 files changed, 185 insertions(+))

Errors

google provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

google-beta provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

@modular-magician
Copy link
Collaborator

Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccSqlDatabaseInstance_pointInTimeRestoreInMultiRegion

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • sql

🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

Copy link
Member

@zli82016 zli82016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

google-beta/services/sql/resource_sql_database_instance.go:3431:3: unknown field Region in struct literal of type sqladmin.PointInTimeRestoreContext

@github-actions github-actions bot requested a review from zli82016 December 30, 2025 10:03
@aditikumarii-google
Copy link
Contributor Author

google-beta/services/sql/resource_sql_database_instance.go:3431:3: unknown field Region in struct literal of type sqladmin.PointInTimeRestoreContext

This is because cl/846845835 marks the region field as GOOGLE_INTERNAL, so the required clients are not generated.
We plan on submitting this PR only when the GOOGLE_INTERNAL tag is removed and the changes in backend are rolled out in prod

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 196 insertions(+), 4 deletions(-))
google-beta provider: Diff ( 3 files changed, 196 insertions(+), 4 deletions(-))

Errors

google provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

google-beta provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

@modular-magician
Copy link
Collaborator

Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccSqlDatabaseInstance_pointInTimeRestoreInMultiRegion

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • sql

🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 191 insertions(+), 4 deletions(-))
google-beta provider: Diff ( 3 files changed, 191 insertions(+), 4 deletions(-))

Errors

google provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

google-beta provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

@modular-magician
Copy link
Collaborator

Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccSqlDatabaseInstance_pointInTimeRestoreInMultiRegion

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • sql

🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

@github-actions
Copy link

github-actions bot commented Jan 2, 2026

@zli82016 This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants