Skip to content

resourceIdentity: block Identity() support from resources that exclude_read #16058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
BBBmau wants to merge 3 commits into
base: FEATURE-BRANCH-resource-identity
Choose a base branch
from
Open

resourceIdentity: block Identity() support from resources that exclude_read #16058

BBBmau wants to merge 3 commits into from

Conversation

@BBBmau
Copy link
Collaborator

@BBBmau BBBmau commented Jan 2, 2026 •
edited
Loading

Needed to be resolved after looking over tests from feature-branch sync

Originally went with adding the identity support for this resource however we run into read identity errors due to the exclude read being set. This is something that we'd need to look into in the future as currently we do not support the ability to set custom_read code that would allow us to be explicit with the identity support in this particular case.

For now we should prevent support on exclude_read resources until we can be explicit within read. We only have 5 resources that have this set so the missing coverage wouldn't be major.

image

Note

Although the resources do not allow us to obtain information about the resource its still worth including identity support on them as we'd still want to be able to identify them through searching across cloud environments where the value that is used to do such a search comes from identity being set in state.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

@BBBmau BBBmau changed the title resourceIdentity: block Identity() support from resources that exclude_read resourceIdentity: add explicit Identity() support on ExternalAccountKey Jan 2, 2026
@BBBmau BBBmau mentioned this pull request Jan 2, 2026
Open
@modular-magician
Copy link
Collaborator

modular-magician commented Jan 2, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 24 insertions(+), 8 deletions(-))
google-beta provider: Diff ( 1 file changed, 24 insertions(+), 8 deletions(-))

@modular-magician
Copy link
Collaborator

modular-magician commented Jan 2, 2026

Tests analytics

Total tests: 1
Passed tests: 0
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • publicca

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccPublicCAExternalAccountKey_publicCaExternalAccountKeyExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

modular-magician commented Jan 2, 2026

🔴 Tests failed during RECORDING mode:
TestAccPublicCAExternalAccountKey_publicCaExternalAccountKeyExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

modular-magician commented Jan 2, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 696 files changed, 691 insertions(+), 87 deletions(-))
google-beta provider: Diff ( 758 files changed, 753 insertions(+), 87 deletions(-))

@BBBmau BBBmau changed the title resourceIdentity: add explicit Identity() support on ExternalAccountKey resourceIdentity: block Identity() support from resources that exclude_read Jan 2, 2026
@BBBmau BBBmau requested a review from shuyama1 January 2, 2026 19:58
@modular-magician
Copy link
Collaborator

modular-magician commented Jan 3, 2026

Tests analytics

Total tests: 3344
Passed tests: 2852
Skipped tests: 420
Affected tests: 72

Click here to see the affected service packages
  • pubsublite
  • sql
  • storagecontrol
  • cloudidentity
  • cloudquotas
  • databasemigrationservice
  • dataprocgdc
  • edgecontainer
  • netapp
  • parametermanagerregional
  • bigqueryanalyticshub
  • billing
  • cloudrun
  • migrationcenter
  • networkconnectivityv1
  • storage
  • tpuv2
  • bigtable
  • gkebackup
  • modelarmorglobal
  • resourcemanager3
  • secretmanagerregional
  • vertexai
  • workbench
  • firebasedataconnect
  • modelarmor
  • alloydb
  • cloudids
  • developerconnect
  • eventarc
  • filestore
  • mlengine
  • networkconnectivity
  • storagebatchoperations
  • kms
  • siteverification
  • bigqueryconnection
  • observability
  • osconfig
  • bigquerydatapolicy
  • privateca
  • apihub
  • chronicle
  • cloudtasks
  • compute
  • dataform
  • firestore
  • cloudrunv2
  • containerattached
  • dns
  • iap
  • parametermanager
  • artifactregistry
  • bigquery
  • cloudasset
  • cloudbuildv2
  • datacatalog
  • firebaseextensions
  • identityplatform
  • managedkafka
  • apigateway
  • biglake
  • blockchainnodeengine
  • datapipeline
  • networksecurity
  • oslogin
  • apphub
  • cloudfunctions2
  • networkmanagement
  • securesourcemanager
  • essentialcontacts
  • gkehub
  • iambeta
  • iamworkforcepool
  • serviceusage
  • bigquerydatapolicyv2
  • redis
  • backupdr
  • contactcenterinsights
  • deploymentmanager
  • firebaseappcheck
  • publicca
  • activedirectory
  • bigqueryreservation
  • saasruntime
  • accesscontextmanager
  • edgenetwork
  • logging
  • lustre
  • osconfigv2
  • beyondcorp
  • composer
  • firebasehosting
  • networkservices
  • securitycentermanagement
  • workstations
  • dataproc
  • memcache
  • parallelstore
  • servicenetworking
  • accessapproval
  • dataplex
  • dialogflowcx
  • containeranalysis
  • gkeonprem
  • looker
  • vpcaccess
  • binaryauthorization
  • colab
  • firebase
  • ces
  • cloudscheduler
  • corebilling
  • gemini
  • iam3
  • tags
  • appengine
  • certificatemanager
  • discoveryengine
  • monitoring
  • orgpolicy
  • sourcerepo
  • vmwareengine
  • apigee
  • cloudbuild
  • documentai
  • firebaseapphosting
  • firebasestorage
  • oracledatabase
  • securitycenter
  • servicedirectory
  • integrations
  • privilegedaccessmanager
  • storageinsights
  • storagetransfer
  • transcoder
  • workflows
  • clouddeploy
  • cloudsecuritycompliance
  • documentaiwarehouse
  • healthcare
  • integrationconnectors
  • secretmanager
  • spanner
  • bigquerydatatransfer
  • clouddomains
  • dialogflow
  • pubsub
  • datalossprevention
  • firebasedatabase
  • gkehub2
  • notebooks
  • resourcemanager
  • securitycenterv2
  • securityposture
  • securityscanner
  • datafusion
  • dataprocmetastore
  • datastream
  • iam2
  • memorystore

Action taken

Found 72 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccAccessContextManager
  • TestAccApigeeApiProduct_apigeeApiProductWithAttributesTestExample
  • TestAccApigeeApiProduct_apigeeApiProductWithLegacyOperationTestExample
  • TestAccApigeeApiProduct_apigeeApiProduct_full
  • TestAccApigeeOrganization_apigeeOrganizationCloudBasicDisableVpcPeeringTestExample
  • TestAccBeyondcorpSecurityGatewayApplicationIamBindingGenerated
  • TestAccBeyondcorpSecurityGatewayApplicationIamBindingGenerated_withCondition
  • TestAccBeyondcorpSecurityGatewayApplicationIamMemberGenerated
  • TestAccBeyondcorpSecurityGatewayApplicationIamMemberGenerated_withCondition
  • TestAccBeyondcorpSecurityGatewayIamBindingGenerated
  • TestAccBeyondcorpSecurityGatewayIamBindingGenerated_withCondition
  • TestAccBeyondcorpSecurityGatewayIamMemberGenerated
  • TestAccBeyondcorpSecurityGatewayIamMemberGenerated_withCondition
  • TestAccBeyondcorpSecurityGatewayIamPolicyGenerated
  • TestAccBeyondcorpSecurityGatewayIamPolicyGenerated_withCondition
  • TestAccBeyondcorpSecurityGateway_beyondcorpSecurityGatewayBasicExample
  • TestAccBeyondcorpSecurityGateway_beyondcorpSecurityGatewayBasicExample_update
  • TestAccBigqueryAnalyticsHubDataExchangeSubscription_bigqueryAnalyticshubDataexchangeSubscriptionUpdate
  • TestAccCloudRunService_cloudRunServiceGpuExample
  • TestAccColabRuntime_update
  • TestAccColabSchedule_colabScheduleFullExample
  • TestAccDataFusionInstance_dataFusionInstanceCmekExample
  • TestAccDataSourceGoogleBackupDRBackupPlanAssociations
  • TestAccDataSourceGoogleBackupDRBackupPlan_basic
  • TestAccDataSourceGoogleBackupDRBackupPlan_csql
  • TestAccDataSourceGoogleBackupDRBackupVault_basic
  • TestAccDataSourceGoogleBackupDRDataSourceReference_basic
  • TestAccDataSourceGoogleBackupDRDataSourceReferences_basic
  • TestAccDataSourceGoogleBackupDRManagementServer_basic
  • TestAccDataSourceGoogleServiceAccountAccessToken_basic
  • TestAccDataformRepositoryIamPolicyGenerated
  • TestAccDataformRepositoryReleaseConfig_dataformRepositoryReleaseConfigExample
  • TestAccDataformRepositoryWorkflowConfig_dataformRepositoryWorkflowConfigExample
  • TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample
  • TestAccDialogflowCXTestCase_update
  • TestAccDiscoveryEngineCmekConfig_discoveryengineCmekconfigDefaultExample
  • TestAccDiscoveryEngineCmekConfig_discoveryengineCmekconfigDefaultExample_update
  • TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
  • TestAccFirestoreDatabase_firestoreCmekDatabaseExample
  • TestAccFirestoreDatabase_firestoreCmekDatabaseInDatastoreModeExample
  • TestAccGKEHubFeature_FleetDefaultMemberConfigPolicyController
  • TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample
  • TestAccIAMBetaWorkloadIdentityPoolProvider_iamWorkloadIdentityPoolProviderOidcUploadKeyExample
  • TestAccIAMBetaWorkloadIdentityPool_beta_update
  • TestAccIAMWorkforcePoolWorkforcePoolProviderScimTenant_update
  • TestAccIAMWorkforcePoolWorkforcePoolProviderScimToken_update
  • TestAccMemcacheInstanceDatasourceConfig
  • TestAccProjectIamMemberRemove_basic
  • TestAccProjectIamMemberRemove_memberInMultipleBindings
  • TestAccProjectIamMemberRemove_multipleMembersInBinding
  • TestAccPubsubSubscription_pubsubSubscriptionTagsExample
  • TestAccRedisClusterDatasource
  • TestAccRedisCluster_automatedBackupConfig
  • TestAccRedisCluster_createClusterWithZoneDistribution
  • TestAccRedisCluster_createUpdateClusterWithNodeType
  • TestAccRedisCluster_createUpdateDeletionProtection
  • TestAccRedisCluster_gcsSource
  • TestAccRedisCluster_managedBackupSource
  • TestAccRedisCluster_persistenceUpdate
  • TestAccRedisCluster_redisClusterMaintenanceVersion
  • TestAccRedisCluster_redisClusterTlsEnabled
  • TestAccRedisCluster_switchoverAndDetachSecondary
  • TestAccRedisCluster_updateClusterEndpoints
  • TestAccRedisCluster_updateRedisConfigs
  • TestAccRedisCluster_updateReplicaCount
  • TestAccRedisCluster_updateShardCount
  • TestAccResourceManager3Capability_resourceManagerCapabilityExample
  • TestAccSqlDatabaseInstance_MysqlSwitchoverSuccess
  • TestAccSqlDatabaseInstance_PostgresSwitchoverSuccess
  • TestAccSqlDatabaseInstance_settings_deletionProtection
  • TestAccSqlDatabaseInstance_settings_deletionProtectionEnabled
  • TestAccVmwareengineExternalAddress_vmwareEngineExternalAddressUpdate

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

modular-magician commented Jan 3, 2026

🟢 Tests passed during RECORDING mode:
TestAccAccessContextManager__access_level [Debug log]
TestAccAccessContextManager__access_level_condition [Debug log]
TestAccAccessContextManager__access_level_custom [Debug log]
TestAccAccessContextManager__access_level_full [Debug log]
TestAccAccessContextManager__access_levels [Debug log]
TestAccAccessContextManager__access_policy [Debug log]
TestAccAccessContextManager__access_policy_scoped [Debug log]
TestAccAccessContextManager__authorized_orgs_desc [Debug log]
TestAccAccessContextManager__service_perimeter [Debug log]
TestAccAccessContextManager__service_perimeter_dry_run_egress_policy [Debug log]
TestAccAccessContextManager__service_perimeter_dry_run_ingress_policy [Debug log]
TestAccAccessContextManager__service_perimeter_update [Debug log]
TestAccAccessContextManager__service_perimeters [Debug log]
TestAccBeyondcorpSecurityGatewayApplicationIamBindingGenerated [Debug log]
TestAccBeyondcorpSecurityGatewayApplicationIamBindingGenerated_withCondition [Debug log]
TestAccBeyondcorpSecurityGatewayApplicationIamMemberGenerated [Debug log]
TestAccBeyondcorpSecurityGatewayApplicationIamMemberGenerated_withCondition [Debug log]
TestAccBeyondcorpSecurityGatewayIamBindingGenerated [Debug log]
TestAccBeyondcorpSecurityGatewayIamBindingGenerated_withCondition [Debug log]
TestAccBeyondcorpSecurityGatewayIamMemberGenerated [Debug log]
TestAccBeyondcorpSecurityGatewayIamMemberGenerated_withCondition [Debug log]
TestAccBeyondcorpSecurityGatewayIamPolicyGenerated [Debug log]
TestAccBeyondcorpSecurityGatewayIamPolicyGenerated_withCondition [Debug log]
TestAccBeyondcorpSecurityGateway_beyondcorpSecurityGatewayBasicExample [Debug log]
TestAccBeyondcorpSecurityGateway_beyondcorpSecurityGatewayBasicExample_update [Debug log]
TestAccColabSchedule_colabScheduleFullExample [Debug log]
TestAccIAMWorkforcePoolWorkforcePoolProviderScimTenant_update [Debug log]
TestAccIAMWorkforcePoolWorkforcePoolProviderScimToken_update [Debug log]
TestAccRedisClusterDatasource [Debug log]
TestAccRedisCluster_automatedBackupConfig [Debug log]
TestAccRedisCluster_createClusterWithZoneDistribution [Debug log]
TestAccRedisCluster_createUpdateClusterWithNodeType [Debug log]
TestAccRedisCluster_createUpdateDeletionProtection [Debug log]
TestAccRedisCluster_gcsSource [Debug log]
TestAccRedisCluster_managedBackupSource [Debug log]
TestAccRedisCluster_persistenceUpdate [Debug log]
TestAccRedisCluster_redisClusterMaintenanceVersion [Debug log]
TestAccRedisCluster_redisClusterTlsEnabled [Debug log]
TestAccRedisCluster_switchoverAndDetachSecondary [Debug log]
TestAccRedisCluster_updateClusterEndpoints [Debug log]
TestAccRedisCluster_updateRedisConfigs [Debug log]
TestAccRedisCluster_updateReplicaCount [Debug log]
TestAccRedisCluster_updateShardCount [Debug log]
TestAccSqlDatabaseInstance_settings_deletionProtection [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode:
TestAccAccessContextManager__gcp_user_access_binding [Error message] [Debug log]
TestAccApigeeApiProduct_apigeeApiProductWithAttributesTestExample [Error message] [Debug log]
TestAccApigeeApiProduct_apigeeApiProductWithLegacyOperationTestExample [Error message] [Debug log]
TestAccApigeeApiProduct_apigeeApiProduct_full [Error message] [Debug log]
TestAccApigeeOrganization_apigeeOrganizationCloudBasicDisableVpcPeeringTestExample [Error message] [Debug log]
TestAccBigqueryAnalyticsHubDataExchangeSubscription_bigqueryAnalyticshubDataexchangeSubscriptionUpdate [Error message] [Debug log]
TestAccCloudRunService_cloudRunServiceGpuExample [Error message] [Debug log]
TestAccColabRuntime_update [Error message] [Debug log]
TestAccDataFusionInstance_dataFusionInstanceCmekExample [Error message] [Debug log]
TestAccDataSourceGoogleBackupDRBackupPlanAssociations [Error message] [Debug log]
TestAccDataSourceGoogleBackupDRBackupPlan_basic [Error message] [Debug log]
TestAccDataSourceGoogleBackupDRBackupPlan_csql [Error message] [Debug log]
TestAccDataSourceGoogleBackupDRBackupVault_basic [Error message] [Debug log]
TestAccDataSourceGoogleBackupDRDataSourceReference_basic [Error message] [Debug log]
TestAccDataSourceGoogleBackupDRDataSourceReferences_basic [Error message] [Debug log]
TestAccDataSourceGoogleBackupDRManagementServer_basic [Error message] [Debug log]
TestAccDataSourceGoogleServiceAccountAccessToken_basic [Error message] [Debug log]
TestAccDataformRepositoryIamPolicyGenerated [Error message] [Debug log]
TestAccDataformRepositoryReleaseConfig_dataformRepositoryReleaseConfigExample [Error message] [Debug log]
TestAccDataformRepositoryWorkflowConfig_dataformRepositoryWorkflowConfigExample [Error message] [Debug log]
TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample [Error message] [Debug log]
TestAccDialogflowCXTestCase_update [Error message] [Debug log]
TestAccDiscoveryEngineCmekConfig_discoveryengineCmekconfigDefaultExample [Error message] [Debug log]
TestAccDiscoveryEngineCmekConfig_discoveryengineCmekconfigDefaultExample_update [Error message] [Debug log]
TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample [Error message] [Debug log]
TestAccFirestoreDatabase_firestoreCmekDatabaseExample [Error message] [Debug log]
TestAccFirestoreDatabase_firestoreCmekDatabaseInDatastoreModeExample [Error message] [Debug log]
TestAccGKEHubFeature_FleetDefaultMemberConfigPolicyController [Error message] [Debug log]
TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample [Error message] [Debug log]
TestAccIAMBetaWorkloadIdentityPoolProvider_iamWorkloadIdentityPoolProviderOidcUploadKeyExample [Error message] [Debug log]
TestAccIAMBetaWorkloadIdentityPool_beta_update [Error message] [Debug log]
TestAccMemcacheInstanceDatasourceConfig [Error message] [Debug log]
TestAccPubsubSubscription_pubsubSubscriptionTagsExample [Error message] [Debug log]
TestAccResourceManager3Capability_resourceManagerCapabilityExample [Error message] [Debug log]
TestAccSqlDatabaseInstance_MysqlSwitchoverSuccess [Error message] [Debug log]
TestAccSqlDatabaseInstance_PostgresSwitchoverSuccess [Error message] [Debug log]
TestAccSqlDatabaseInstance_settings_deletionProtectionEnabled [Error message] [Debug log]

🔴 Several tests terminated during RECORDING mode.

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@shuyama1
Copy link
Member

shuyama1 commented Jan 4, 2026

/gcbrun

@modular-magician
Copy link
Collaborator

modular-magician commented Jan 4, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 696 files changed, 691 insertions(+), 87 deletions(-))
google-beta provider: Diff ( 758 files changed, 753 insertions(+), 87 deletions(-))

@modular-magician
Copy link
Collaborator

modular-magician commented Jan 4, 2026

Tests analytics

Total tests: 3360
Passed tests: 2897
Skipped tests: 421
Affected tests: 42

Click here to see the affected service packages
  • bigqueryconnection
  • bigqueryreservation
  • iambeta
  • memcache
  • mlengine
  • pubsub
  • vmwareengine
  • certificatemanager
  • netapp
  • networkservices
  • securityposture
  • workflows
  • artifactregistry
  • firebaseextensions
  • kms
  • logging
  • oslogin
  • privilegedaccessmanager
  • edgenetwork
  • vpcaccess
  • accesscontextmanager
  • secretmanagerregional
  • securitycenterv2
  • apphub
  • bigquerydatapolicyv2
  • bigtable
  • datafusion
  • eventarc
  • apigee
  • cloudids
  • deploymentmanager
  • workstations
  • alloydb
  • blockchainnodeengine
  • cloudsecuritycompliance
  • firebasedataconnect
  • storagebatchoperations
  • backupdr
  • composer
  • dataform
  • gkeonprem
  • sourcerepo
  • storage
  • storagetransfer
  • clouddeploy
  • colab
  • gkehub
  • oracledatabase
  • resourcemanager
  • servicedirectory
  • containerattached
  • datacatalog
  • dataprocgdc
  • documentai
  • beyondcorp
  • biglake
  • ces
  • gemini
  • iam2
  • bigquery
  • dataplex
  • firestore
  • osconfig
  • securitycentermanagement
  • sql
  • transcoder
  • clouddomains
  • discoveryengine
  • firebasedatabase
  • firebasehosting
  • publicca
  • networkmanagement
  • cloudrun
  • cloudrunv2
  • memorystore
  • migrationcenter
  • monitoring
  • securesourcemanager
  • securityscanner
  • bigquerydatatransfer
  • cloudbuildv2
  • cloudtasks
  • containeranalysis
  • databasemigrationservice
  • tpuv2
  • cloudfunctions2
  • parallelstore
  • contactcenterinsights
  • firebase
  • firebaseappcheck
  • gkebackup
  • gkehub2
  • privateca
  • storageinsights
  • apigateway
  • appengine
  • bigqueryanalyticshub
  • billing
  • integrations
  • saasruntime
  • apihub
  • cloudidentity
  • compute
  • iam3
  • modelarmorglobal
  • networkconnectivity
  • securitycenter
  • serviceusage
  • bigquerydatapolicy
  • looker
  • servicenetworking
  • parametermanager
  • vertexai
  • dataproc
  • binaryauthorization
  • cloudquotas
  • dialogflowcx
  • edgecontainer
  • parametermanagerregional
  • pubsublite
  • firebasestorage
  • observability
  • siteverification
  • chronicle
  • cloudbuild
  • datalossprevention
  • essentialcontacts
  • firebaseapphosting
  • healthcare
  • identityplatform
  • notebooks
  • cloudasset
  • filestore
  • osconfigv2
  • redis
  • resourcemanager3
  • secretmanager
  • activedirectory
  • datastream
  • iamworkforcepool
  • lustre
  • modelarmor
  • tags
  • dataprocmetastore
  • orgpolicy
  • developerconnect
  • iap
  • workbench
  • dns
  • documentaiwarehouse
  • integrationconnectors
  • storagecontrol
  • accessapproval
  • corebilling
  • datapipeline
  • dialogflow
  • networkconnectivityv1
  • spanner
  • cloudscheduler
  • managedkafka
  • networksecurity

Action taken

Found 42 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccAccessContextManager
  • TestAccApigeeApiProduct_apigeeApiProductWithAttributesTestExample
  • TestAccApigeeApiProduct_apigeeApiProductWithLegacyOperationTestExample
  • TestAccApigeeApiProduct_apigeeApiProduct_full
  • TestAccApigeeOrganization_apigeeOrganizationCloudBasicDisableVpcPeeringTestExample
  • TestAccBigqueryAnalyticsHubDataExchangeSubscription_bigqueryAnalyticshubDataexchangeSubscriptionUpdate
  • TestAccCloudRunService_cloudRunServiceGpuExample
  • TestAccColabRuntime_update
  • TestAccDataFusionInstance_dataFusionInstanceCmekExample
  • TestAccDataSourceGoogleBackupDRBackupPlanAssociations
  • TestAccDataSourceGoogleBackupDRBackupPlan_basic
  • TestAccDataSourceGoogleBackupDRBackupPlan_csql
  • TestAccDataSourceGoogleBackupDRBackupVault_basic
  • TestAccDataSourceGoogleBackupDRDataSourceReference_basic
  • TestAccDataSourceGoogleBackupDRDataSourceReferences_basic
  • TestAccDataSourceGoogleBackupDRManagementServer_basic
  • TestAccDataSourceGoogleServiceAccountAccessToken_basic
  • TestAccDataformRepositoryIamPolicyGenerated
  • TestAccDataformRepositoryReleaseConfig_dataformRepositoryReleaseConfigExample
  • TestAccDataformRepositoryWorkflowConfig_dataformRepositoryWorkflowConfigExample
  • TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample
  • TestAccDialogflowCXTestCase_dialogflowcxTestCaseFullExample
  • TestAccDialogflowCXTestCase_update
  • TestAccDiscoveryEngineCmekConfig_discoveryengineCmekconfigDefaultExample
  • TestAccDiscoveryEngineCmekConfig_discoveryengineCmekconfigDefaultExample_update
  • TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
  • TestAccFirestoreDatabase_firestoreCmekDatabaseExample
  • TestAccFirestoreDatabase_firestoreCmekDatabaseInDatastoreModeExample
  • TestAccGKEHubFeature_FleetDefaultMemberConfigPolicyController
  • TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample
  • TestAccIAMBetaWorkloadIdentityPoolProvider_iamWorkloadIdentityPoolProviderOidcUploadKeyExample
  • TestAccIAMBetaWorkloadIdentityPool_beta_update
  • TestAccMemcacheInstanceDatasourceConfig
  • TestAccProjectIamMemberRemove_basic
  • TestAccProjectIamMemberRemove_multipleMembersInBinding
  • TestAccPubsubSubscription_pubsubSubscriptionTagsExample
  • TestAccResourceManager3Capability_resourceManagerCapabilityExample
  • TestAccSqlDatabaseInstance_MysqlSwitchoverSuccess
  • TestAccSqlDatabaseInstance_PostgresSwitchoverSuccess
  • TestAccSqlDatabaseInstance_settings_deletionProtectionEnabled
  • TestAccVertexAIReasoningEngine_vertexAiReasoningEngineBasicExample
  • TestAccVmwareengineExternalAddress_vmwareEngineExternalAddressUpdate

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

modular-magician commented Jan 4, 2026

🟢 Tests passed during RECORDING mode:
TestAccAccessContextManager__access_level [Debug log]
TestAccAccessContextManager__access_level_condition [Debug log]
TestAccAccessContextManager__access_level_custom [Debug log]
TestAccAccessContextManager__access_level_full [Debug log]
TestAccAccessContextManager__access_levels [Debug log]
TestAccAccessContextManager__access_policy [Debug log]
TestAccAccessContextManager__access_policy_scoped [Debug log]
TestAccAccessContextManager__authorized_orgs_desc [Debug log]
TestAccAccessContextManager__service_perimeter [Debug log]
TestAccAccessContextManager__service_perimeter_dry_run_egress_policy [Debug log]
TestAccAccessContextManager__service_perimeter_dry_run_ingress_policy [Debug log]
TestAccAccessContextManager__service_perimeter_update [Debug log]
TestAccAccessContextManager__service_perimeters [Debug log]
TestAccSqlDatabaseInstance_settings_deletionProtectionEnabled [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode:
TestAccAccessContextManager__gcp_user_access_binding [Error message] [Debug log]
TestAccApigeeApiProduct_apigeeApiProductWithAttributesTestExample [Error message] [Debug log]
TestAccApigeeApiProduct_apigeeApiProductWithLegacyOperationTestExample [Error message] [Debug log]
TestAccApigeeApiProduct_apigeeApiProduct_full [Error message] [Debug log]
TestAccApigeeOrganization_apigeeOrganizationCloudBasicDisableVpcPeeringTestExample [Error message] [Debug log]
TestAccBigqueryAnalyticsHubDataExchangeSubscription_bigqueryAnalyticshubDataexchangeSubscriptionUpdate [Error message] [Debug log]
TestAccCloudRunService_cloudRunServiceGpuExample [Error message] [Debug log]
TestAccColabRuntime_update [Error message] [Debug log]
TestAccDataFusionInstance_dataFusionInstanceCmekExample [Error message] [Debug log]
TestAccDataSourceGoogleBackupDRBackupPlanAssociations [Error message] [Debug log]
TestAccDataSourceGoogleBackupDRBackupPlan_basic [Error message] [Debug log]
TestAccDataSourceGoogleBackupDRBackupPlan_csql [Error message] [Debug log]
TestAccDataSourceGoogleBackupDRBackupVault_basic [Error message] [Debug log]
TestAccDataSourceGoogleBackupDRDataSourceReference_basic [Error message] [Debug log]
TestAccDataSourceGoogleBackupDRDataSourceReferences_basic [Error message] [Debug log]
TestAccDataSourceGoogleBackupDRManagementServer_basic [Error message] [Debug log]
TestAccDataSourceGoogleServiceAccountAccessToken_basic [Error message] [Debug log]
TestAccDataformRepositoryIamPolicyGenerated [Error message] [Debug log]
TestAccDataformRepositoryReleaseConfig_dataformRepositoryReleaseConfigExample [Error message] [Debug log]
TestAccDataformRepositoryWorkflowConfig_dataformRepositoryWorkflowConfigExample [Error message] [Debug log]
TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample [Error message] [Debug log]
TestAccDialogflowCXTestCase_dialogflowcxTestCaseFullExample [Error message] [Debug log]
TestAccDialogflowCXTestCase_update [Error message] [Debug log]
TestAccDiscoveryEngineCmekConfig_discoveryengineCmekconfigDefaultExample [Error message] [Debug log]
TestAccDiscoveryEngineCmekConfig_discoveryengineCmekconfigDefaultExample_update [Error message] [Debug log]
TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample [Error message] [Debug log]
TestAccFirestoreDatabase_firestoreCmekDatabaseExample [Error message] [Debug log]
TestAccFirestoreDatabase_firestoreCmekDatabaseInDatastoreModeExample [Error message] [Debug log]
TestAccGKEHubFeature_FleetDefaultMemberConfigPolicyController [Error message] [Debug log]
TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample [Error message] [Debug log]
TestAccIAMBetaWorkloadIdentityPoolProvider_iamWorkloadIdentityPoolProviderOidcUploadKeyExample [Error message] [Debug log]
TestAccIAMBetaWorkloadIdentityPool_beta_update [Error message] [Debug log]
TestAccMemcacheInstanceDatasourceConfig [Error message] [Debug log]
TestAccPubsubSubscription_pubsubSubscriptionTagsExample [Error message] [Debug log]
TestAccResourceManager3Capability_resourceManagerCapabilityExample [Error message] [Debug log]
TestAccSqlDatabaseInstance_MysqlSwitchoverSuccess [Error message] [Debug log]
TestAccSqlDatabaseInstance_PostgresSwitchoverSuccess [Error message] [Debug log]
TestAccVertexAIReasoningEngine_vertexAiReasoningEngineBasicExample [Error message] [Debug log]

🔴 Several tests terminated during RECORDING mode.

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@BBBmau
Copy link
Collaborator Author

BBBmau commented Jan 5, 2026

we get a missing identity after update error on TestAccColabRuntime_update

This is due to the custom_update being utilized for the resource

I can push a commit that adds support within this PR or open an entirely new one, would have to be after the triage meeting @shuyama1

@modular-magician
Copy link
Collaborator

modular-magician commented Jan 6, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 696 files changed, 715 insertions(+), 87 deletions(-))
google-beta provider: Diff ( 758 files changed, 777 insertions(+), 87 deletions(-))

@modular-magician
Copy link
Collaborator

modular-magician commented Jan 7, 2026

Tests analytics

Total tests: 3337
Passed tests: 2877
Skipped tests: 419
Affected tests: 41

Click here to see the affected service packages
  • clouddomains
  • memorystore
  • ces
  • colab
  • lustre
  • networkmanagement
  • billing
  • datalossprevention
  • dataproc
  • gkeonprem
  • kms
  • cloudscheduler
  • developerconnect
  • documentai
  • integrationconnectors
  • observability
  • osconfig
  • corebilling
  • netapp
  • accessapproval
  • bigqueryconnection
  • dialogflowcx
  • discoveryengine
  • dns
  • managedkafka
  • storagecontrol
  • securitycenterv2
  • servicedirectory
  • tags
  • apphub
  • binaryauthorization
  • cloudbuildv2
  • clouddeploy
  • firebaseextensions
  • modelarmor
  • networkconnectivityv1
  • saasruntime
  • bigquerydatatransfer
  • datafusion
  • integrations
  • parametermanager
  • secretmanager
  • securesourcemanager
  • securityscanner
  • cloudquotas
  • privilegedaccessmanager
  • gkebackup
  • publicca
  • resourcemanager
  • securitycenter
  • memcache
  • bigquery
  • bigqueryanalyticshub
  • bigtable
  • firebasedataconnect
  • firebasestorage
  • iambeta
  • looker
  • biglake
  • dataplex
  • dialogflow
  • firebaseapphosting
  • gemini
  • gkehub
  • identityplatform
  • networkservices
  • bigquerydatapolicy
  • firestore
  • osconfigv2
  • storage
  • apigateway
  • cloudrun
  • composer
  • sql
  • certificatemanager
  • chronicle
  • cloudasset
  • beyondcorp
  • cloudrunv2
  • cloudsecuritycompliance
  • dataprocgdc
  • datastream
  • cloudtasks
  • dataform
  • deploymentmanager
  • migrationcenter
  • monitoring
  • oracledatabase
  • siteverification
  • cloudbuild
  • datacatalog
  • edgenetwork
  • filestore
  • redis
  • spanner
  • storagetransfer
  • activedirectory
  • bigquerydatapolicyv2
  • bigqueryreservation
  • containerattached
  • eventarc
  • firebasedatabase
  • iam2
  • privateca
  • blockchainnodeengine
  • compute
  • databasemigrationservice
  • gkehub2
  • iam3
  • servicenetworking
  • vmwareengine
  • accesscontextmanager
  • apigee
  • cloudfunctions2
  • cloudidentity
  • contactcenterinsights
  • firebasehosting
  • iamworkforcepool
  • dataprocmetastore
  • firebase
  • logging
  • securityposture
  • storagebatchoperations
  • tpuv2
  • alloydb
  • mlengine
  • networksecurity
  • iap
  • orgpolicy
  • oslogin
  • apihub
  • essentialcontacts
  • networkconnectivity
  • edgecontainer
  • sourcerepo
  • appengine
  • healthcare
  • notebooks
  • resourcemanager3
  • secretmanagerregional
  • modelarmorglobal
  • backupdr
  • parallelstore
  • securitycentermanagement
  • storageinsights
  • vertexai
  • workstations
  • documentaiwarehouse
  • parametermanagerregional
  • transcoder
  • vpcaccess
  • cloudids
  • serviceusage
  • workbench
  • datapipeline
  • pubsublite
  • containeranalysis
  • firebaseappcheck
  • pubsub
  • workflows
  • artifactregistry

Action taken

Found 41 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccAccessContextManager
  • TestAccApigeeApiProduct_apigeeApiProductWithAttributesTestExample
  • TestAccApigeeApiProduct_apigeeApiProductWithLegacyOperationTestExample
  • TestAccApigeeApiProduct_apigeeApiProduct_full
  • TestAccApigeeOrganization_apigeeOrganizationCloudBasicDisableVpcPeeringTestExample
  • TestAccBigqueryAnalyticsHubDataExchangeSubscription_bigqueryAnalyticshubDataexchangeSubscriptionUpdate
  • TestAccCloudRunService_cloudRunServiceGpuExample
  • TestAccDataFusionInstance_dataFusionInstanceCmekExample
  • TestAccDataSourceGoogleBackupDRBackupPlanAssociations
  • TestAccDataSourceGoogleBackupDRBackupPlan_basic
  • TestAccDataSourceGoogleBackupDRBackupPlan_csql
  • TestAccDataSourceGoogleBackupDRBackupVault_basic
  • TestAccDataSourceGoogleBackupDRDataSourceReference_basic
  • TestAccDataSourceGoogleBackupDRDataSourceReferences_basic
  • TestAccDataSourceGoogleBackupDRManagementServer_basic
  • TestAccDataSourceGoogleServiceAccountAccessToken_basic
  • TestAccDataformRepositoryIamPolicyGenerated
  • TestAccDataformRepositoryReleaseConfig_dataformRepositoryReleaseConfigExample
  • TestAccDataformRepositoryWorkflowConfig_dataformRepositoryWorkflowConfigExample
  • TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample
  • TestAccDialogflowCXTestCase_dialogflowcxTestCaseFullExample
  • TestAccDialogflowCXTestCase_update
  • TestAccDiscoveryEngineCmekConfig_discoveryengineCmekconfigDefaultExample
  • TestAccDiscoveryEngineCmekConfig_discoveryengineCmekconfigDefaultExample_update
  • TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
  • TestAccFirestoreDatabase_firestoreCmekDatabaseExample
  • TestAccFirestoreDatabase_firestoreCmekDatabaseInDatastoreModeExample
  • TestAccGKEHubFeature_FleetDefaultMemberConfigPolicyController
  • TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample
  • TestAccIAMBetaWorkloadIdentityPoolProvider_iamWorkloadIdentityPoolProviderOidcUploadKeyExample
  • TestAccIAMBetaWorkloadIdentityPool_beta_update
  • TestAccMemcacheInstanceDatasourceConfig
  • TestAccProjectIamMemberRemove_basic
  • TestAccProjectIamMemberRemove_memberInMultipleBindings
  • TestAccProjectIamMemberRemove_multipleMembersInBinding
  • TestAccPubsubSubscription_pubsubSubscriptionTagsExample
  • TestAccResourceManager3Capability_resourceManagerCapabilityExample
  • TestAccSqlDatabaseInstance_MysqlSwitchoverSuccess
  • TestAccSqlDatabaseInstance_PostgresSwitchoverSuccess
  • TestAccSqlDatabaseInstance_settings_deletionProtection
  • TestAccVmwareengineExternalAddress_vmwareEngineExternalAddressUpdate

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

modular-magician commented Jan 7, 2026

🟢 Tests passed during RECORDING mode:
TestAccAccessContextManager__access_level [Debug log]
TestAccAccessContextManager__access_level_condition [Debug log]
TestAccAccessContextManager__access_level_custom [Debug log]
TestAccAccessContextManager__access_level_full [Debug log]
TestAccAccessContextManager__access_levels [Debug log]
TestAccAccessContextManager__access_policy [Debug log]
TestAccAccessContextManager__access_policy_scoped [Debug log]
TestAccAccessContextManager__authorized_orgs_desc [Debug log]
TestAccAccessContextManager__service_perimeter [Debug log]
TestAccAccessContextManager__service_perimeter_dry_run_egress_policy [Debug log]
TestAccAccessContextManager__service_perimeter_dry_run_ingress_policy [Debug log]
TestAccAccessContextManager__service_perimeter_update [Debug log]
TestAccAccessContextManager__service_perimeters [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode:
TestAccAccessContextManager__gcp_user_access_binding [Error message] [Debug log]
TestAccApigeeApiProduct_apigeeApiProductWithAttributesTestExample [Error message] [Debug log]
TestAccApigeeApiProduct_apigeeApiProductWithLegacyOperationTestExample [Error message] [Debug log]
TestAccApigeeApiProduct_apigeeApiProduct_full [Error message] [Debug log]
TestAccApigeeOrganization_apigeeOrganizationCloudBasicDisableVpcPeeringTestExample [Error message] [Debug log]
TestAccBigqueryAnalyticsHubDataExchangeSubscription_bigqueryAnalyticshubDataexchangeSubscriptionUpdate [Error message] [Debug log]
TestAccCloudRunService_cloudRunServiceGpuExample [Error message] [Debug log]
TestAccDataFusionInstance_dataFusionInstanceCmekExample [Error message] [Debug log]
TestAccDataSourceGoogleBackupDRBackupPlanAssociations [Error message] [Debug log]
TestAccDataSourceGoogleBackupDRBackupPlan_basic [Error message] [Debug log]
TestAccDataSourceGoogleBackupDRBackupPlan_csql [Error message] [Debug log]
TestAccDataSourceGoogleBackupDRBackupVault_basic [Error message] [Debug log]
TestAccDataSourceGoogleBackupDRDataSourceReference_basic [Error message] [Debug log]
TestAccDataSourceGoogleBackupDRDataSourceReferences_basic [Error message] [Debug log]
TestAccDataSourceGoogleBackupDRManagementServer_basic [Error message] [Debug log]
TestAccDataSourceGoogleServiceAccountAccessToken_basic [Error message] [Debug log]
TestAccDataformRepositoryIamPolicyGenerated [Error message] [Debug log]
TestAccDataformRepositoryReleaseConfig_dataformRepositoryReleaseConfigExample [Error message] [Debug log]
TestAccDataformRepositoryWorkflowConfig_dataformRepositoryWorkflowConfigExample [Error message] [Debug log]
TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample [Error message] [Debug log]
TestAccDialogflowCXTestCase_dialogflowcxTestCaseFullExample [Error message] [Debug log]
TestAccDialogflowCXTestCase_update [Error message] [Debug log]
TestAccDiscoveryEngineCmekConfig_discoveryengineCmekconfigDefaultExample [Error message] [Debug log]
TestAccDiscoveryEngineCmekConfig_discoveryengineCmekconfigDefaultExample_update [Error message] [Debug log]
TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample [Error message] [Debug log]
TestAccFirestoreDatabase_firestoreCmekDatabaseExample [Error message] [Debug log]
TestAccFirestoreDatabase_firestoreCmekDatabaseInDatastoreModeExample [Error message] [Debug log]
TestAccGKEHubFeature_FleetDefaultMemberConfigPolicyController [Error message] [Debug log]
TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample [Error message] [Debug log]
TestAccIAMBetaWorkloadIdentityPoolProvider_iamWorkloadIdentityPoolProviderOidcUploadKeyExample [Error message] [Debug log]
TestAccIAMBetaWorkloadIdentityPool_beta_update [Error message] [Debug log]
TestAccMemcacheInstanceDatasourceConfig [Error message] [Debug log]
TestAccPubsubSubscription_pubsubSubscriptionTagsExample [Error message] [Debug log]
TestAccResourceManager3Capability_resourceManagerCapabilityExample [Error message] [Debug log]
TestAccSqlDatabaseInstance_MysqlSwitchoverSuccess [Error message] [Debug log]
TestAccSqlDatabaseInstance_PostgresSwitchoverSuccess [Error message] [Debug log]
TestAccSqlDatabaseInstance_settings_deletionProtection [Error message] [Debug log]

🔴 Several tests terminated during RECORDING mode.

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@github-actions
Copy link

github-actions bot commented Jan 7, 2026

@shuyama1 This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shuyama1 shuyama1 Awaiting requested review from shuyama1

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

service/publicca

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@BBBmau @modular-magician @shuyama1