Dialogflow tool new - #18235
Conversation
Added support for freeFormContext, agentCoachingContext, translationContext, agentFeedbackContext, and customerMessageGenerationContext. Enforced mutual exclusivity using exactly_one_of. Made summarizationContext optional (non-breaking). Added timeouts and tunedModel support.
Added 'tools' property to Generator.yaml and updated samples to demonstrate linkage. Fixed pre-existing errors in Tool connector and datastore samples.
- Update summarizationContext.version candidates in Generator.yaml to 5.0 and 6.0 - Update versions in samples to 6.0 - Update versions in handwritten tests to 5.0 and 6.0 - Add valid path to dialogflow_generator_with_tools OpenAPI spec
d05972a to
8785808
Compare
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @SirGitsalot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
|
@SirGitsalot This PR has been waiting for review for 3 weekdays. Please take a look! Use the label |
SirGitsalot
left a comment
There was a problem hiding this comment.
Seems generally sound, but you need to add some sample tests
|
@matt-degraffenreid, this PR is waiting for action from you. If no action is taken, this PR will be closed in 28 days. Please address any comments or change requests, or re-request review from a core reviewer if no action is required. This notification can be disabled with the |
|
@matt-degraffenreid, this PR is waiting for action from you. If no action is taken, this PR will be closed in 14 days. Please address any comments or change requests, or re-request review from a core reviewer if no action is required. This notification can be disabled with the |
Implemented google_dialogflow_tool resource in MMv1 with support for open_api_spec.
Added function_spec, connector_spec, and data_store_spec to Tool.yaml. Configured authentication options and marked sensitive fields. Also recorded
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 6e5b0e2: Diff reportYour PR generated the following diffs in downstream repositories:
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_dialogflow_tool" "primary" {
connector_spec {
actions {
connection_action_id = # value needed
entity_operation {
entity_id = # value needed
operation = # value needed
}
input_fields = # value needed
output_fields = # value needed
}
name = # value needed
}
data_store_spec {
data_store_connections {
data_store = # value needed
data_store_type = # value needed
document_processing_mode = # value needed
}
}
description = # value needed
display_name = # value needed
function_spec {
input_schema = # value needed
output_schema = # value needed
}
location = # value needed
open_api_spec {
authentication {
api_key_config {
api_key = # value needed
key_name = # value needed
request_location = # value needed
}
bearer_token_config {
token = # value needed
}
oauth_config {
client_id = # value needed
client_secret = # value needed
oauth_grant_type = # value needed
scopes = # value needed
token_endpoint = # value needed
}
service_agent_auth_config {
service_agent_auth = # value needed
}
}
text_schema = # value needed
}
tool_key = # value needed
}
Missing service labelsThe following new resources do not have corresponding service labels:
If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels. Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode 🟢 All tests passed in Replaying mode! No Recording was needed. View the replaying VCR build log @matt-degraffenreid, @SirGitsalot VCR tests complete for 6e5b0e2! |
Added a basic sample template for Dialogflow Tool and updated existing samples with the required tool_key. Added the basic sample to Tool.yaml.
6e5b0e2 to
dae1c34
Compare
Added samples covering all branches of specification and authentication unions for Dialogflow Tool. Added google_dialogflow_tool to service/dialogflow-cx in enrolled_teams.yml to fix missing service label.
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit dae1c34: Diff reportYour PR generated the following diffs in downstream repositories:
Breaking Change(s) DetectedThe following breaking change(s) were detected within your pull request.
If you believe this detection to be incorrect please raise the concern with your reviewer. Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_dialogflow_generator" "primary" {
agent_coaching_context {
instructions {
agent_action = # value needed
condition = # value needed
display_details = # value needed
display_name = # value needed
system_action = # value needed
triggering_event = # value needed
}
output_language_code = # value needed
search_config {
datastores = # value needed
search_engine = # value needed
}
}
agent_feedback_context {
instructions {
agent_action = # value needed
condition = # value needed
display_details = # value needed
display_name = # value needed
system_action = # value needed
triggering_event = # value needed
}
version = # value needed
}
customer_message_generation_context {
customization {
scenario = # value needed
}
version = # value needed
}
free_form_context {
text = # value needed
}
translation_context {
agent_language_code = # value needed
customer_language_code = # value needed
translation_customization {
glossary_terms {
agent_language_glossary = # value needed
customer_language_glossary = # value needed
}
sentence_translations {
agent_language_sentence = # value needed
customer_language_sentence = # value needed
}
}
version = # value needed
}
tuned_model = # value needed
}
Resource: resource "google_dialogflow_tool" "primary" {
connector_spec {
actions {
connection_action_id = # value needed
entity_operation {
entity_id = # value needed
operation = # value needed
}
input_fields = # value needed
output_fields = # value needed
}
name = # value needed
}
data_store_spec {
data_store_connections {
data_store = # value needed
data_store_type = # value needed
document_processing_mode = # value needed
}
}
function_spec {
input_schema = # value needed
output_schema = # value needed
}
open_api_spec {
authentication {
api_key_config {
api_key = # value needed
key_name = # value needed
request_location = # value needed
}
bearer_token_config {
token = # value needed
}
oauth_config {
client_id = # value needed
client_secret = # value needed
oauth_grant_type = # value needed
scopes = # value needed
token_endpoint = # value needed
}
service_agent_auth_config {
service_agent_auth = # value needed
}
}
}
}
Missing service labelsThe following new resources do not have corresponding service labels:
If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels. Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the recording VCR build log or the debug logs folder for detailed results. @matt-degraffenreid, @SirGitsalot VCR tests complete for dae1c34! |
…edModel to fix breaking change

Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.