Skip to content

[Filestore] Enable regional endpoint (REP) support - #18605

Open
astra1503 wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
astra1503:add-filestore-rep
Open

[Filestore] Enable regional endpoint (REP) support#18605
astra1503 wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
astra1503:add-filestore-rep

Conversation

@astra1503

@astra1503 astra1503 commented Aug 12, 2026

Copy link
Copy Markdown

Description

Enables Regional Endpoint (REP) support for Filestore resources (google_filestore_instance, google_filestore_backup, google_filestore_snapshot).

Changes Made

  1. Updated mmv1/products/filestore/product.yaml to include rep_url for both GA (v1) and Beta (v1beta1) endpoints.
  2. Updated mmv1/templates/terraform/constants/filestore_instance.go.tmpl to extract location and pass it to FilestoreOperationWaitTime.

Testing

  • Generated GA and Beta provider code via make provider PRODUCT=filestore.
  • Verified local compilation and tests passing via go test ./google/services/filestore.
filestore: added regional endpoint (REP) support for `google_filestore_instance`, `google_filestore_backup`, and `google_filestore_snapshot`

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Aug 12, 2026
@github-actions

Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@SirGitsalot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions
github-actions Bot requested a review from SirGitsalot August 12, 2026 09:41
@astra1503

Copy link
Copy Markdown
Author

/gcbrun

@modular-magician modular-magician added service/filestore and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Aug 12, 2026
@modular-magician

modular-magician commented Aug 12, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 67dbfa1:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 11 files changed, 99 insertions(+), 15 deletions(-)
google-beta provider View Diff 11 files changed, 99 insertions(+), 15 deletions(-)
terraform-google-conversion View Diff 1 file changed, 2 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
21 21 0 0
Affected Service Packages
  • filestore

Learn how VCR tests work


Step 1: Replaying Mode

🟢 All tests passed in Replaying mode! No Recording was needed.

View the replaying VCR build log

@astra1503, @SirGitsalot VCR tests complete for 67dbfa1!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants