Remove google_compute_reservation.reservation_block_count field - #18611
Remove google_compute_reservation.reservation_block_count field#18611NA2047 wants to merge 1 commit into
Conversation
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
rileykarson
left a comment
There was a problem hiding this comment.
Looks like history got munged here, can you correct it? Thanks!
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit aafea4a: Diff reportYour PR generated the following diffs in downstream repositories:
Breaking Change(s) DetectedThe following breaking change(s) were detected within your pull request.
If you believe this detection to be incorrect please raise the concern with your reviewer. Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_compute_service_attachment" "primary" {
consumer_accept_lists {
endpoint_url = # value needed
}
}
Errors
Test reportImportant Manual Verification Required VCR cannot automatically execute the following tests added in this PR. Please verify them manually: 🔴 TestAccContainerNodePool_namePrefix_long Analytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 78 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Manual Verification Required: New tests were added that are skipped in presubmit tests. See the "Manual Verification Required" section at the top for details. 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the recording VCR build log or the debug logs folder for detailed results. @NA2047, @rileykarson VCR tests complete for aafea4a! |
aafea4a to
e89ae5f
Compare
Fixed! |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit e89ae5f: Diff reportYour PR generated the following diffs in downstream repositories:
Breaking Change(s) DetectedThe following breaking change(s) were detected within your pull request.
If you believe this detection to be incorrect please raise the concern with your reviewer. Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 60 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the recording VCR build log or the debug logs folder for detailed results. @NA2047, @rileykarson VCR tests complete for e89ae5f! |
Fix for
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.