Add immutable attribute to TlsInspectionPolicy parameters - #18624
Add immutable attribute to TlsInspectionPolicy parameters#18624JamesDuncanNz wants to merge 1 commit into
Conversation
Added 'immutable' attribute to parameters in TlsInspectionPolicy.
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @ScottSuarez, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 731d5f9: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode 🟢 All tests passed in Replaying mode! No Recording was needed. View the replaying VCR build log @JamesDuncanNz, @ScottSuarez VCR tests complete for 731d5f9! |
|
@ScottSuarez This PR has been waiting for review for 3 weekdays. Please take a look! Use the label |
Description
Mark
nameandlocationparameters asimmutable: trueonTlsInspectionPolicy.Previously,
immutable: truewas missing on the URL parametersnameandlocationinmmv1/products/networksecurity/TlsInspectionPolicy.yaml. As a result, the generated Terraform schema did not haveForceNew: true, causing Terraform to erroneously plan an in-place update when either field was changed. During apply, this resulted in an invalidPATCHrequest to the new resource name/location endpoint and failed on subsequent state read with:Adding
immutable: trueensures Terraform correctly plans a destroy-and-recreate (ForceNew) whennameorlocationis changed.Release Note Template for Downstream PRs (will be copied)