Skip to content

add google_monitoring_snooze resource - #18628

Open
tavasyag wants to merge 4 commits into
GoogleCloudPlatform:mainfrom
tavasyag:snooze-alerts
Open

add google_monitoring_snooze resource#18628
tavasyag wants to merge 4 commits into
GoogleCloudPlatform:mainfrom
tavasyag:snooze-alerts

Conversation

@tavasyag

@tavasyag tavasyag commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Adds the google_monitoring_snooze resource

Fixes hashicorp/terraform-provider-google#13913

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

`google_monitoring_snooze`

@modular-magician

modular-magician commented Aug 13, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit fac51f9:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 4 files changed, 1068 insertions(+)
google-beta provider View Diff 4 files changed, 1068 insertions(+)
terraform-google-conversion View Diff 1 file changed, 211 insertions(+)
Open in Cloud Shell View Diff 4 files changed, 132 insertions(+)

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_monitoring_snooze (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_monitoring_snooze" "primary" {
  criteria {
    filter = # value needed
  }
}

Missing service labels

The following new resources do not have corresponding service labels:

  • google_monitoring_snooze

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

Test report

Analytics

Total Tests Passed Skipped Affected
61 56 4 1
Affected Service Packages
  • monitoring

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccMonitoringSnooze_monitoringSnoozeBasicExample

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccMonitoringSnooze_monitoringSnoozeBasicExample

🟢 All tests passed!

View the recording VCR build log or the debug logs folder for detailed results.

@tavasyag VCR tests complete for fac51f9!

@tavasyag

Copy link
Copy Markdown
Contributor Author

Note: The Snooze api has no delete method so terraform destroy cancels/removes from state only via exclude_delete/deletion_policy_exclude

@modular-magician

modular-magician commented Aug 13, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 201c92c:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 4 files changed, 1068 insertions(+)
google-beta provider View Diff 4 files changed, 1068 insertions(+)
terraform-google-conversion View Diff 1 file changed, 211 insertions(+)
Open in Cloud Shell View Diff 4 files changed, 132 insertions(+)

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_monitoring_snooze (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_monitoring_snooze" "primary" {
  criteria {
    filter = # value needed
  }
}

Missing service labels

The following new resources do not have corresponding service labels:

  • google_monitoring_snooze

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

Test report

Analytics

Total Tests Passed Skipped Affected
61 57 4 0
Affected Service Packages
  • monitoring

Learn how VCR tests work


Step 1: Replaying Mode

🟢 All tests passed in Replaying mode! No Recording was needed.

View the replaying VCR build log

@tavasyag VCR tests complete for 201c92c!

@modular-magician

modular-magician commented Aug 13, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 2a926ac:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 4 files changed, 1182 insertions(+)
google-beta provider View Diff 4 files changed, 1182 insertions(+)
terraform-google-conversion View Diff 1 file changed, 211 insertions(+)
Open in Cloud Shell View Diff 8 files changed, 265 insertions(+)

Missing service labels

The following new resources do not have corresponding service labels:

  • google_monitoring_snooze

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

Test report

Analytics

Total Tests Passed Skipped Affected
62 57 4 1
Affected Service Packages
  • monitoring

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccMonitoringSnooze_monitoringSnoozeFilterExample

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccMonitoringSnooze_monitoringSnoozeFilterExample

🟢 All tests passed!

View the recording VCR build log or the debug logs folder for detailed results.

@tavasyag VCR tests complete for 2a926ac!

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Aug 13, 2026
@tavasyag
tavasyag marked this pull request as ready for review August 13, 2026 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-approval Pull requests that need reviewer's approval to run presubmit tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add snooze resource to Monitoring

2 participants