Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion functions/firebase_remote_config/composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,6 @@
},
"require-dev": {
"google/auth": "^1.14",
"google/cloud-logging": "^1.21"
"google/cloud-logging": "^2.0"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Upgrading to google/cloud-logging v2.0.0 introduces breaking changes that will cause the deployment tests to fail. In v2, the Entry::info() method returns an array with snake_case keys (matching the underlying protobuf fields) instead of the camelCase keys used in v1. Specifically, the check for isset($info['textPayload']) in functions/firebase_remote_config/test/DeployTest.php (line 117) will fail because the key is now text_payload. Since these tests are not run by the CI system (as noted in the file header), this breakage might go unnoticed. You should update the test code to use the getter method $log->textPayload(), which is compatible with both versions, or update the array key access to text_payload. Additionally, google/cloud-logging v2.0.0 requires google/auth version ^1.18; consider updating line 12 to match this requirement.

}
}
Loading