Skip to content

fix(ops): resolve binaries from GOBIN before PATH in manifests_regen #2009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bwplotka wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(ops): resolve binaries from GOBIN before PATH in manifests_regen #2009

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions ops/gmpctl/lib.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -444,13 +444,13 @@ release-lib::manifests_regen() {
# dependencies, instead the ones populated by bingo on old versions.
# NOTE: Only needed before 0.19.
if [[ -f "${dir}/.bingo/variables.env" ]]; then
cp "${dir}/.bingo/variables.env" "${dir}/.bingo/variables.env.bak"
trap "mv \"${dir}/.bingo/variables.env.bak\" \"${dir}/.bingo/variables.env\" 2>/dev/null || true" EXIT
echo "#!/bin/bash" >"${dir}/.bingo/variables.env" # Clean the file.
fi
cp "${dir}/.bingo/variables.env" "${dir}/.bingo/variables.env.bak"
trap "mv \"${dir}/.bingo/variables.env.bak\" \"${dir}/.bingo/variables.env\" 2>/dev/null || true" EXIT
echo "#!/bin/bash" >"${dir}/.bingo/variables.env" # Clean the file.
fi

echo "🔄 Regenerating manifests..."
YQ="$(command -v yq)" HELM="$(command -v helm)" ADDLICENSE="$(command -v addlicense)" bash "${dir}/hack/presubmit.sh" manifests
echo "🔄 Regenerating manifests..."
YQ="${GOBIN}/yq" HELM="${GOBIN}/helm" ADDLICENSE="${GOBIN}/addlicense" bash "${dir}/hack/presubmit.sh" manifests

@bwplotka bwplotka Jul 24, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: Check if PATH change can be ignored later on


echo "✅ Manifests regenerated"
return 0
Expand Down
Loading