refactor[cartesian]: update treeir representation of the vertical loop#2688
Merged
Conversation
romanc
force-pushed
the
romanc/treeir-vertical-loop
branch
3 times, most recently
from
8dcce8b to
fce412a
Compare
twicki
approved these changes
Jul 8, 2026
twicki
left a comment
twicki
left a comment
Contributor
There was a problem hiding this comment.
Makes sense to split sequential from vertical loops at the treeir stage
romanc
force-pushed
the
romanc/treeir-vertical-loop
branch
from
fce412a to
e565f6d
Compare
Contributor
Author
|
(rebased on top of current |
romanc
force-pushed
the
romanc/treeir-vertical-loop
branch
from
cc8891b to
173faf9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Change the representation of vertical loop sections in the treeir of the dace backend. This doesn't change anything - just makes the tree ir look nicer (see issue for motivation).
This PR contains unrelated cleanup in
test_code_generation.py.Related issue: #2681
Requirements
N/A
N/A