优化 JFXSpinner 动画生成逻辑 by Glavo · Pull Request #5804 · HMCL-dev/HMCL

Glavo · 2026-03-18T06:19:15Z

简化代码
在未启用动画时，使用简单的线性旋转动画

Copilot

Pull request overview

此 PR 旨在优化（简化）JFXSpinner 的动画关键帧生成逻辑，并在禁用动画时提供一个更轻量的线性旋转动画作为替代，以更好地适配全局动画开关（AnimationUtils.isAnimationEnabled()）。

Changes:

将原先重复构建 KeyFrame[] 的逻辑改为向 List<KeyFrame> 追加关键帧，减少样板代码
当启用动画时，继续使用原先的“伸缩弧线 + 旋转”的关键帧序列
当禁用动画时，改用固定弧长的线性旋转动画（更简单、开销更小）

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

HMCL/src/main/java/com/jfoenix/skins/JFXSpinnerSkin.java

Copilot

Pull request overview

该 PR 旨在优化 JFXSpinnerSkin 的不确定（indeterminate）模式动画生成逻辑，以减少代码复杂度，并在“动画未启用”时切换为更简单的线性旋转效果。

Changes:

移除旧的分段 KeyFrame 生成/颜色切换逻辑，改为通过 addKeyFrames(...) 统一拼装关键帧列表
引入 AnimationUtils.isAnimationEnabled() 分支：启用动画时使用原有复杂关键帧序列；未启用时使用线性旋转 Timeline
调整动画启停逻辑，改为在 updateAnimation() 中直接 play/pause，并移除 control.sceneProperty() 监听

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

HMCL/src/main/java/com/jfoenix/skins/JFXSpinnerSkin.java

Copilot

Pull request overview

该 PR 针对 JFXSpinnerSkin 的不确定进度（indeterminate）动画创建逻辑做了重构，以减少重复代码，并在全局禁用动画时改用更简单的线性旋转动画，以适配 HMCL 的动画开关策略。

Changes:

将原先按颜色分段构造 KeyFrame[] 的逻辑，重构为通过 addKeyFrames(...) 生成并集中组装 KeyFrame 列表。
引入 AnimationUtils.isAnimationEnabled()：动画启用时使用原复杂弧线动画；禁用时使用简单线性旋转。
简化 updateAnimation()：直接基于 treeShowingProperty 进行 play/pause 控制，并在非 indeterminate 时清理动画。

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

HMCL/src/main/java/com/jfoenix/skins/JFXSpinnerSkin.java

+
        timeline.setCycleCount(Timeline.INDEFINITE);
-        timeline.setDelay(Duration.ZERO);
        timeline.playFromStart();


Copilot

Pull request overview

该 PR 优化了 JFXSpinnerSkin 的动画关键帧生成与播放控制逻辑，并在“关闭动画”设置下改为使用更简单的线性旋转动画，以降低动画复杂度与开销。

Changes:

重构不定进度（indeterminate）动画的关键帧生成逻辑，移除多段颜色切换帧并用列表组装关键帧
将动画启停逻辑集中到 updateProgress()，并基于 TreeShowingProperty 控制播放/暂停
在动画未启用时（AnimationUtils.isAnimationEnabled() == false），使用更简单的线性旋转时间线

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

HMCL/src/main/java/com/jfoenix/skins/JFXSpinnerSkin.java

-        } else if (isTreeShowing) {
-            createTransition();
+        } else { // determinate
+            clearAnimation();


Copilot

Pull request overview

本 PR 优化 JFXSpinnerSkin 的动画生成与播放控制逻辑，简化原先的关键帧拼接方式，并在禁用动画时改用更轻量的线性旋转动画，以降低复杂度并适配“关闭动画”的配置。

Changes:

将不确定进度（indeterminate）动画关键帧生成逻辑重构为列表拼装方式，并移除旧的颜色/帧生成分支。
将动画启停逻辑收敛到 updateProgress()，结合 TreeShowingProperty 控制显示时播放、隐藏时暂停。
在 AnimationUtils.isAnimationEnabled() 为 false 时，使用简单线性旋转 Timeline 作为替代动画。

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

HMCL/src/main/java/com/jfoenix/skins/JFXSpinnerSkin.java

Copilot

Pull request overview

本 PR 优化了 JFXSpinnerSkin 的动画生成与进度更新逻辑，将原本分散的初始化/动画控制流程合并到单一的 updateProgress() 路径中，并在关闭动画设置时提供更简单的线性旋转方案，以降低复杂度并提升可维护性。

Changes:

将不确定/确定进度的处理统一收敛到新的 updateProgress() 实现中，减少状态变量与重复逻辑。
重构不确定进度动画：用 addKeyFrames 组合关键帧，并在动画禁用时改用简单线性旋转 Timeline。
依赖 TreeShowingProperty 来在节点不可见时暂停动画，避免无意义的播放。

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Glavo added 10 commits March 18, 2026 13:19

简化 JFXSpinnerSkin 颜色常量逻辑

9d04d9d

支持禁用动画时的 JFXSpinner 简化动画

abd39af

为 JFXSpinner 动画添加线性插值器

90a9eda

优化 JFXSpinner 关键帧数组管理

a6393a9

内联 JFXSpinner 关键帧数组生成逻辑

e231371

调整 JFXSpinner 动画起始角度偏移

13c0959

重构 JFXSpinner 关键帧生成逻辑

75d36fe

修复 JFXSpinner 弧形填充和时间线初始化

d6a14ec

移除 VersionsPage 测试用延迟代码

61de612

调整 JFXSpinner 弧形长度和动画时长

e5c25c5

Glavo requested a review from Copilot March 18, 2026 06:21

Copilot started reviewing on behalf of Glavo March 18, 2026 06:22 View session

调整 JFXSpinner 动画时长为 1.2 秒

70a870d

Copilot AI reviewed Mar 18, 2026

View reviewed changes

HMCL/src/main/java/com/jfoenix/skins/JFXSpinnerSkin.java Outdated Show resolved Hide resolved

HMCL/src/main/java/com/jfoenix/skins/JFXSpinnerSkin.java Outdated Show resolved Hide resolved

Glavo added 2 commits March 18, 2026 14:30

简化 JFXSpinner 动画控制逻辑

eac88f6

重命名 JFXSpinner 关键帧方法为 addKeyFrames

a965346

Glavo requested a review from Copilot March 18, 2026 06:35

Copilot started reviewing on behalf of Glavo March 18, 2026 06:35 View session

Copilot AI reviewed Mar 18, 2026

View reviewed changes

HMCL/src/main/java/com/jfoenix/skins/JFXSpinnerSkin.java Outdated Show resolved Hide resolved

HMCL/src/main/java/com/jfoenix/skins/JFXSpinnerSkin.java Show resolved Hide resolved

移除 JFXSpinner 时间线延迟设置

35e671e

Glavo requested a review from Copilot March 18, 2026 06:44

Copilot started reviewing on behalf of Glavo March 18, 2026 06:45 View session

Copilot AI reviewed Mar 18, 2026

View reviewed changes

HMCL/src/main/java/com/jfoenix/skins/JFXSpinnerSkin.java Outdated Show resolved Hide resolved

HMCL/src/main/java/com/jfoenix/skins/JFXSpinnerSkin.java Outdated

timeline.setCycleCount(Timeline.INDEFINITE);

timeline.setDelay(Duration.ZERO);

timeline.playFromStart();

Glavo added 4 commits March 18, 2026 14:52

简化 JFXSpinner 初始化和清理逻辑

503c589

重构 JFXSpinner 进度更新和动画逻辑

eaf64d8

移除 JFXSpinner 多余空行

0e2a670

简化 JFXSpinner 注释格式

4360a85

Glavo requested a review from Copilot March 18, 2026 07:13

Copilot started reviewing on behalf of Glavo March 18, 2026 07:14 View session

Copilot AI reviewed Mar 18, 2026

View reviewed changes

HMCL/src/main/java/com/jfoenix/skins/JFXSpinnerSkin.java

} else if (isTreeShowing) {

createTransition();

} else { // determinate

clearAnimation();

设置 JFXSpinner 弧形起始角度为 90 度

f6f75fa

Glavo requested a review from Copilot March 18, 2026 07:27

Copilot started reviewing on behalf of Glavo March 18, 2026 07:27 View session

Copilot AI reviewed Mar 18, 2026

View reviewed changes

HMCL/src/main/java/com/jfoenix/skins/JFXSpinnerSkin.java Outdated Show resolved Hide resolved

HMCL/src/main/java/com/jfoenix/skins/JFXSpinnerSkin.java Outdated Show resolved Hide resolved

HMCL/src/main/java/com/jfoenix/skins/JFXSpinnerSkin.java Show resolved Hide resolved

Glavo added 3 commits March 18, 2026 15:34

优化 JFXSpinner 动画初始化和弧形属性设置

fb28f62

优化 JFXSpinner 弧形长度和插值器设置

9594dcf

update createTransition

d252212

Glavo requested a review from Copilot March 18, 2026 07:41

Copilot started reviewing on behalf of Glavo March 18, 2026 07:42 View session

Copilot AI reviewed Mar 18, 2026

View reviewed changes

Glavo merged commit 704eb32 into HMCL-dev:main Mar 18, 2026
6 checks passed

Glavo deleted the spinner branch March 18, 2026 07:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

优化 JFXSpinner 动画生成逻辑#5804

优化 JFXSpinner 动画生成逻辑#5804
Glavo merged 22 commits intoHMCL-dev:mainfrom
Glavo:spinner

Glavo commented Mar 18, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

Glavo commented Mar 18, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants