Conversation
crevulus
reviewed
Dec 1, 2025
crevulus
left a comment
crevulus
left a comment
There was a problem hiding this comment.
Hi Karim,
Great work on this assignment. Your code is very well organised and easy to follow, and you've made the most of programmatic JS to seed your db.
There's some data concerns I've noted that will make your dataset more nuanced and, therefore, your queries will be more useful/reflective of real-world databases. Please fix those concerns and the other comments when you can.
Author
|
I’ve pushed fixes addressing all review comments. Please let me know if anything else is needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.