Skip to content

feat: add random background Spoon#305

Draft
roeeyn wants to merge 1 commit into
Hammerspoon:masterfrom
roeeyn:roeeyn/random-background
Draft

feat: add random background Spoon#305
roeeyn wants to merge 1 commit into
Hammerspoon:masterfrom
roeeyn:roeeyn/random-background

Conversation

@roeeyn

@roeeyn roeeyn commented Jul 4, 2023

Copy link
Copy Markdown

I've always enjoyed the dynamism of having a fresh background with every Hammerspoon config reload. I have used both the UnsplashRandom and UnsplashZ Spoons in the past, but recently, they've started to exhibit issues. The core of this problem stems from Unsplash's decision to deprecate the source endpoint, which both of these Spoons heavily relied upon.

In light of this, I took the initiative to develop a new Spoon that taps into the modern Unsplash API. The primary distinction with this approach is the necessity of an API key, a measure implemented by Unsplash to safeguard against misuse. However, I am currently in the process of finalizing the best practices for documenting these instructions.

I sincerely appreciate any feedback you might have and look forward to collaborating with the community to make this Spoon the best it can be. 😄

@muescha

muescha commented Jul 24, 2023

Copy link
Copy Markdown
Contributor

i miss documentation and a variable in obj for unsplash_api_key
like obj.unsplash_api_key = ""

-> since the API call need the key it should be mandatory at start maybe as parameter for start

additionaly I would allow the user to change the interval and the url of the service (in case they change again the api)

@cmsj cmsj closed this Aug 7, 2024
@cmsj cmsj reopened this Aug 7, 2024
@cmsj cmsj marked this pull request as draft August 7, 2024 13:31
@cmsj

cmsj commented Aug 7, 2024

Copy link
Copy Markdown
Member

@roeeyn apologies for the delay in getting to this - there are some errors from the docstrings linter that would need to be taken care of before this can merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants