Fix DLL to use Win32 native ICON resources for Windows icon browser compatibility#4
Draft
Claude wants to merge 3 commits into
Draft
Fix DLL to use Win32 native ICON resources for Windows icon browser compatibility#4Claude wants to merge 3 commits into
Claude wants to merge 3 commits into
Conversation
Co-authored-by: HaydenReeve <39004735+HaydenReeve@users.noreply.github.com>
HaydenReeve
requested changes
Mar 4, 2026
…mentation Co-authored-by: HaydenReeve <39004735+HaydenReeve@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The generated .dll used .NET embedded resources, which are inaccessible to Windows Explorer's icon picker and other Win32 icon browsers. These tools require native
RT_GROUP_ICONresources compiled via RC.EXE.Changes
.rcresource script +resource.hheader with sequential resource IDs (101-621) for all 521 icons/NOENTRYflagOutput
Running
BuildResourceDll.batproducesbin/WindowsIcons.dllcontaining Win32 native ICON resources accessible to:ExtractIcon,LoadIcon,SHGetFileInfoAPIsThe .NET project (
WindowsIcons.csproj) remains for backward compatibility but is documented as incompatible with icon browsers.Original prompt