Skip to content

Update to 26.1.2#409

Open
rafi67000 wants to merge 3 commits into
Hexeption:1.21from
rafi67000:26.1
Open

Update to 26.1.2#409
rafi67000 wants to merge 3 commits into
Hexeption:1.21from
rafi67000:26.1

Conversation

@rafi67000
Copy link
Copy Markdown

No description provided.

@karl-police
Copy link
Copy Markdown

Where do you get the mcp_version from? And does newer versions still need all this? I heard somewhere that they'd all come deobfuscated or something.

@rafi67000
Copy link
Copy Markdown
Author

Where do you get the mcp_version from? And does newer versions still need all this? I heard somewhere that they'd all come deobfuscated or something.

Yes it is needed because vineflower's output is not clean or ready to compile so MCPConfig is still needed (post decompilation patching).
It's also much easier to just use mcpconfig instead of reinventing the wheel

@rafi67000 rafi67000 changed the title Update to 26.1 Update to 26.1.2 Apr 17, 2026
@karl-police
Copy link
Copy Markdown

Where do you get the mcp_version from? And does newer versions still need all this? I heard somewhere that they'd all come deobfuscated or something.

Yes it is needed because vineflower's output is not clean or ready to compile so MCPConfig is still needed (post decompilation patching). It's also much easier to just use mcpconfig instead of reinventing the wheel

When making changes to the decompiled source. What's a good way to save the changes, so it's easy to port them over to newer versions?

@rafi67000
Copy link
Copy Markdown
Author

Generating diff file and applying the patches.

@karl-police
Copy link
Copy Markdown

Generating diff file and applying the patches.

With the git CLI?

@rafi67000
Copy link
Copy Markdown
Author

Generating diff file and applying the patches.

With the git CLI?

git diff or diff (linux)

@ultimatumof01
Copy link
Copy Markdown

this seems to work, but when running runClient, it complains that gradle only supports up to java 24. ive tried other combinations of gradle and java, but none work (mcp plugin doesnt support newer gradles). so that needs to be fixed. however, building works, so you can still run the modified client if you bother to add a version to a minecraft launcher

@rafi67000
Copy link
Copy Markdown
Author

then I fear forgegradle7 is inevitable 🤷🏼

@ultimatumof01
Copy link
Copy Markdown

how do we implement this. i really need my client to work lol

@rafi67000
Copy link
Copy Markdown
Author

I haven't familiarised with forgegradle7 yet unfortunely but I fear I will have to now

@ultimatumof01
Copy link
Copy Markdown

what could there possibly be to learn? also i cant even find it: https://maven.minecraftforge.net/net/minecraftforge/gradle/ForgeGradle/maven-metadata.xml

@rafi67000
Copy link
Copy Markdown
Author

ForgeGradle 7 and all related components was a rewrite from scratch and here we wouldn't even use "ForgeGradle" but rather ForgeDev.

@vytskalt
Copy link
Copy Markdown

Local variable names aren't available :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants