-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Phase 3: pausable command lifecycle (pause / resume / cancel) #2732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
aboimpinto
wants to merge
62
commits into
Hmbown:main
from
aboimpinto:feat/allowed-tools-phase3-fresh
Closed
Changes from all commits
Commits
Show all changes
62 commits
Select commit
Hold shift + click to select a range
2a58dc3
Phase 3: pausable command lifecycle (pause/resume/cancel)
aboimpinto 3b49de0
fix: correct UiTheme field names in sidebar pause indicator
aboimpinto 9813852
fix: keep pausable flag across TurnStarted, handle cancel-while-pause…
aboimpinto 4b91ae1
fix: use shared Arc<StdMutex<bool>> for paused flag (bypasses Op chan…
aboimpinto 878d981
fix: keep paused/paused_cancelled visible after turn ends, show 'Paus…
aboimpinto d3819b2
debug: add tracing::debug! at pause key points (set_paused, pause gat…
aboimpinto 2625d71
fix: show (Pausing) in WorkBench during transition, let 'continue' me…
aboimpinto 372a0d9
fix: any message while paused unpauses and sends, instead of blocking…
aboimpinto f79814e
fix: cancel old turn when unpausing with a new message to prevent com…
aboimpinto 2b28bc8
fix: when paused and user types, cancel old turn; consume message so …
aboimpinto 7f33a04
fix: pause gate cancels turn instead of returning tool error (prevent…
aboimpinto 580e7d7
fix: mark hunt as Hunted on successful turn completion (green checkma…
aboimpinto 2dd228f
feat: play icon ▶ while running (yellow), green checkmark ✓ on comple…
aboimpinto 687c3a8
fix: cancel-while-paused now also calls engine_handle.cancel() — actu…
aboimpinto 8692935
fix: merge pause indicator into the goal line (replaces icon instead …
aboimpinto e7439ef
fix: 'continue'/'resume' unpauses and lets message through (one keyst…
aboimpinto 6420195
fix: clear todos and plan state when a new slash command starts (no s…
aboimpinto b5265e8
fix: second ESC while paused returns CancelRequest even after turn en…
aboimpinto 5f39234
fix: cancel-while-paused clears flag directly (not via set_paused) to…
aboimpinto 24e10ef
fix: new slash command clears pause state (app + engine flag); safety…
aboimpinto 079b62e
fix: safety sync clears engine flag when app.paused is false, even if…
aboimpinto b9f4a42
test: add 8 pause lifecycle tests (indicator states, goal icons) + fi…
aboimpinto 0d8981c
fix: standardised status messages — Request is Pausing / Request was …
aboimpinto 6f3557c
fix: remove redundant Op::SetPaused try_send from set_paused() — avoi…
aboimpinto ca6845d
test: verify new slash command after cancel clears all pause state
aboimpinto c5871c9
fix: remove unused Op::SetPaused variant and handler (dead code warning)
aboimpinto d676a9c
fix: clear hunt.quarry on cancel so model doesn't resume old command …
aboimpinto 1e7f988
fix: clear hunt.quarry on successful completion so model stops being …
aboimpinto 4c04baa
feat: pause now lets messages through (no cancel); quarry saved/resto…
aboimpinto 8905e25
fix: set pause message as quarry so model knows command is on hold in…
aboimpinto edcb4fb
test: add pause_sets_pause_message_as_quarry; strengthen pause instru…
aboimpinto 9729951
fix: clear hunt.quarry on pause so goal system doesn't prompt model t…
aboimpinto c8b5ba4
test: add lifecycle workflow tests (pause->continue->complete, pause-…
aboimpinto 6863211
fix: keep quarry on cancel so WorkBench shows ✘ with the original goa…
aboimpinto 06f86f4
fix: display paused_quarry in WorkBench when hunt.quarry is None duri…
aboimpinto 15f9206
fix: non-continue message while paused cancels old turn + clears hunt…
aboimpinto 6ac0f90
fix: detect 'continue the scan' / 'resume the paused command' as resu…
aboimpinto ed524e3
fix: keep pause indicator visible while paused_quarry exists, even af…
aboimpinto 3760c9c
test: non_continue_while_paused_clears_system_prompt_goal — proves hu…
aboimpinto 38301f2
test: workbench_visible_through_pause_ask_resume — proves WorkBench p…
aboimpinto a93c311
fix: inject cancellation notice into message when non-continue sent w…
aboimpinto e2f19a9
test: resume_switches_icon_from_pause_to_play — verifies icon changes…
aboimpinto 6b15315
debug: add tracing::debug! for pause state in sidebar_work_summary
aboimpinto 1647862
fix: intercept resume in submit_or_steer_message (catches Steer path …
aboimpinto 21e67df
chore: remove unused mut on message in submit_or_steer_message
aboimpinto 54e8165
debug: add tracing at submit_or_steer interception point
aboimpinto f9f86e9
fix: add resume interception in steer_user_message (belt-and-suspenders)
aboimpinto e8b8482
fix: detect 'please continue' / 'resume the command' at any word posi…
aboimpinto aaaa684
cleanup: remove debug eprintln traces
aboimpinto e7695d5
cleanup: remove debug traces, run cargo fmt
aboimpinto 655fd8e
fix: resolve all clippy warnings (collapsible_if, unnecessary_map_or,…
aboimpinto 5de8254
fix: use set_paused in CancelRequest; use match on try_lock with warn…
aboimpinto 922c1c3
feat: use LLM evaluation for resume detection (replace fragile keywor…
aboimpinto 516f302
fix: LLM-evaluation approach — keep paused_quarry for WorkBench, rest…
aboimpinto 11bf824
feat: remove keyword interception entirely — pure LLM evaluation for …
aboimpinto 3c3ee94
feat: separate icon logic from pause_indicator, fix TurnCompleted ver…
aboimpinto f2a4179
refactor: extract add_paused_evaluation_note helper, remove duplicate…
aboimpinto 0049780
fix: restore quarry.is_some() guard on TurnCompleted — prevents check…
aboimpinto b6e4e10
fix: workflow_paused includes paused_quarry — icon stays ⏸ after typi…
aboimpinto 8c690a3
fix: add keyword detection back for icon/checkmark — LLM note still h…
aboimpinto 365a6f7
chore: final cleanup before PR — format, centralize LLM eval note, ve…
aboimpinto 4f67d63
fix: steer_user_message now clears pause state (engine flag + app.pau…
aboimpinto File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.