fix(tui): #2742 avoid static Ollama model suggestions#2772
Conversation
Harvested from PR #2742 by @reidliu41 Ollama model IDs are local passthrough tags, so /model static completions should not suggest hosted DeepSeek API models or entrench the stale default local tag. Keep the picker on auto/current/saved local models while the existing /models path fetches installed tags from the configured endpoint. Verification: cargo fmt --all -- --check; git diff --check; ./scripts/release/check-versions.sh; cargo test -p codewhale-tui --bin codewhale-tui --locked ollama -- --nocapture; cargo clippy -p codewhale-tui --bin codewhale-tui --locked -- -D warnings. Co-authored-by: reidliu41 <61492567+reidliu41@users.noreply.github.com>
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hmbown has reached the 50-review limit for trial accounts. To continue receiving code reviews, upgrade your plan.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes hosted DeepSeek API model IDs from Ollama /model completions, ensuring that the model picker preserves the current or saved local Ollama tag instead of relying on stale static defaults. Corresponding unit tests have been added to verify this behavior. There are no review comments, and I have no additional feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
1 participant
Summary
deepseek-coder:1.3bdefault to another UI surface./modelstatic completions from suggesting hosted DeepSeek API IDs.autoplus the current/saved local Ollama tag; installed tags still come from the existing live/modelspath.Contributor credit
Harvested from PR #2742 by @reidliu41.Co-authored-by: reidliu41 <61492567+reidliu41@users.noreply.github.com>.Verification
cargo fmt --all -- --checkgit diff --check./scripts/release/check-versions.shcargo test -p codewhale-tui --bin codewhale-tui --locked ollama -- --nocapturecargo clippy -p codewhale-tui --bin codewhale-tui --locked -- -D warningspython3 scripts/check-coauthor-trailers.py --author-map .github/AUTHOR_MAP --range origin/codex/v0.9.0-stewardship..HEAD --check-authorsRelease boundary
No tag, publish, GitHub Release, version bump, or release artifact push was performed.