Introduce python_major_minor_version DSL - #23481
Merged
Merged
Conversation
8 tasks
Member
Author
|
Cc @MikeMcQuaid |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new Formula DSL helper in Language::Python::Virtualenv to expose Language::Python.major_minor_version via a shorter call site, plus a spec to verify delegation.
Changes:
- Introduce
python_major_minor_version(python)as a delegating DSL helper for formulas includingLanguage::Python::Virtualenv. - Add an RSpec example asserting the helper delegates to
Language::Python.major_minor_version.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| Library/Homebrew/language/python.rb | Adds a new public DSL helper method delegating to Language::Python.major_minor_version. |
| Library/Homebrew/test/language/python/virtualenv_spec.rb | Adds a spec covering the new helper method鈥檚 delegation behavior. |
馃挕 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Member
Author
|
Waiting for the discussion in #23479 (comment) to finish, as we might go in another direction |
iMichka
force-pushed
the
python_major_minor_version
branch
from
August 10, 2026 07:36
44b69fc to
9e8e2d4
Compare
This is a shorthand version for Language::Python.major_minor_version
iMichka
force-pushed
the
python_major_minor_version
branch
from
August 10, 2026 07:41
9e8e2d4 to
ec271a7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a shorthand version for Language::Python.major_minor_version
brewcommands to reproduce the bug?brew lgtm(style, typechecking and tests) locally?