#13 hotfix to resolve SN for automation#14
Open
hailiang-wang wants to merge 3 commits into
Open
Conversation
Author
|
Travis 的错误，并不是这个PR导致的。
|
Owner
|
辛苦了，稍晚一些处理呀 |
hailiang-wang
commented
Dec 12, 2017
| this.params = _.assign(this.params, this.context.request.body); | ||
| } else { | ||
| this.params = {}; | ||
| } |
Author
There was a problem hiding this comment.
@Houfeng 之前的修改没有考虑到_query, query, body会覆盖的情况，导致传入了 query就没有写body到params, 现在对三个参数进行merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.