Add @JsonInclude(NON_ABSENT) to optional fields in SetSuggestedPromptsParams - #466
Merged
Merged
Conversation
…sParams Without this annotation, Optional.empty() fields are serialized as null in the JSON payload, which the Slack API may reject or misinterpret. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
yyakhnytsia
reviewed
Jul 29, 2026
yyakhnytsia
left a comment
yyakhnytsia
left a comment
Contributor
There was a problem hiding this comment.
reviewed, left comment.
| return getChannelId(); | ||
| } | ||
|
|
||
| @JsonInclude(JsonInclude.Include.NON_ABSENT) |
Contributor
There was a problem hiding this comment.
What if we put this annotation in the class level?
Same behavior, cleaner — applies to all optional fields without repeating the annotation on each getter. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this annotation, Optional.empty() fields are serialized as null in the JSON payload, which the Slack API may reject or misinterpret.