refactor: initialize translation pipeline from config#44
Open
ClemDoum wants to merge 1 commit into
Open
Conversation
078f655 to
0396302
Compare
0396302 to
5f441e0
Compare
Contributor
Author
|
Addresses: #26 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Make the translation worker API more generic by allowing multiple translation pipeline implementation.
Initializes the translation pipeline from a config object and decoralated instanciation of pipeline component and loading of language specific resources:
Fixed translation format to be consistent with ES translator translations.
Changes
datashare-pythonAdded
DatashareLanguageto reflect DS language formatting and validation (uppercase language names)IETFLanguageto support localsLanguage = DatashareLanguage | IETFLanguageTranslationto reflect translation format in DSFixed
Document.content_translatedfrom adict[str, str]to alist[Translation]translation-workerAdded
TranslatorandSentenceSplitterabstraction and made argos component inherit from themTranslationConfigChanged