Add surrogate free indexed strategies - #50
Merged
Conversation
Do not train surrogate at initialization when dataset_y is empty
vreshniak
force-pushed
the
indexed_strategies
branch
from
July 22, 2026 17:50
f867119 to
0f86d61
Compare
Contributor
|
Could you add tests for the new strategies? Unit tests alone should be fine. You can either use the existing file in API looks fine |
Signed-off-by: Lance-Drane <Lance-Drane@users.noreply.github.com>
Contributor
Author
|
@Lance-Drane I added unit tests for indexed strategies |
Lance-Drane
reviewed
Aug 6, 2026
Comment on lines
+402
to
+418
| SingleStrategyType = Literal[ | ||
| ############################# | ||
| # surrogate free strategies | ||
| 'center', | ||
| 'corners', | ||
| 'grid', | ||
| 'chebyshev', | ||
| 'latin_hypercube', | ||
| 'random', | ||
| ############################# | ||
| # surrogate based strategies | ||
| 'uncertainty', | ||
| 'expected_improvement', | ||
| 'upper_confidence_bound', | ||
| 'upper_confidence_bound_nomad', | ||
| 'polymer_acl_sampler', | ||
| ] |
Contributor
There was a problem hiding this comment.
I noticed that 'hypercube' was removed from SingleStrategyType, which is causing a few tests to fail:
- test_hypercube_single_point
- test_hypercube_single_point_discrete
- test_hypercube_single_point_discrete_2D
Is this intended? We should either add hypercube back as a strategy or remove the failing tests.
Contributor
Author
There was a problem hiding this comment.
I added hypercube strategy back
Contributor
|
everything passes, merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Indexed Strategies Support and Improve Strategy Handling
Summary
This PR introduces indexed strategies (surrogate-free sampling methods) and refactors strategy handling throughout the DIAL service.
Features
Indexed Strategies
Adds new surrogate-free sampling strategies that don't require model training:
center: Sample at domain center pointcorners: Sample at domain corner pointsgrid: Uniform grid-based samplingchebyshev: Chebyshev node-based samplinglatin_hypercube: Latin hypercube design samplingNew Examples
2d_rosenbrock_client_with_strategies.pydemonstrating available strategiesChanges Overview
Files Modified
src/dial_service/utilities/strategies.pysrc/dial_dataclass/dial_dataclass.pysrc/dial_service/dial_service.pysrc/dial_service/core.pyscripts/2d_rosenbrock_client_with_strategies.py