IQSS11976 Fix File Replace #12107
Merged
IQSS11976 Fix File Replace #12107
+4
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdurbin
approved these changes
Jan 23, 2026
Member
pdurbin
left a comment
pdurbin
left a comment
There was a problem hiding this comment.
Seems like a reasonable fix. Approving.
github-project-automation
bot
moved this from Ready for Triage
to Ready for QA ⏩
in IQSS Dataverse Project
cmbz
added
FY26 Sprint 15
github-project-automation
bot
moved this from QA ✅
to Merged 🚀
in IQSS Dataverse Project
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: As noted in #11976, attempting to replace a non-tabular file was failing due to a change made in v6.8. This PR has a fix.
Which issue(s) this PR closes:
Special notes for your reviewer: The bug happens when the OptionalFileParams is created from the existing file (as in the JSF UI) but not when it is created from JSON - as from the current API which requires you to send the metadata rather than allowing you to just replace the file and use the current metadata - as long as you don't send a dataFileTags array (even empty). (FWIW: There was a test reported in the issue with the SPA where replace works. I think that's because the SPA doesn't send "dataFileTags":[] in it's JSON - unlike how it sends "categories":[]. If I make the same API call with an empty dataFileTags array it fails the same way as the JSF UI.)
Suggestions on how to test this: Click replace for a non-tabular file and see it fail/succeed after the PR.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?: included.
Additional documentation: