Skip to content

Non-square FusedGradedMatrix#167

Merged
mtfishman merged 17 commits intomainfrom
ld-nonsquare
May 6, 2026
Merged

Non-square FusedGradedMatrix#167
mtfishman merged 17 commits intomainfrom
ld-nonsquare

Conversation

@lkdvos
Copy link
Copy Markdown
Contributor

@lkdvos lkdvos commented May 4, 2026

Refactors FusedGradedMatrix and FusedGradedVector to support rectangular (non-square) block structures with asymmetric codomain/domain sectors.

  • Storage model: replaces the single sectors::Vector + blocks::Vector block-diagonal layout with Dictionary{S,Int} axes (codomain, domain / axis) plus a Dictionary{S,D} of stored blocks keyed only at sectors common to both axes.
  • Drops insert_missing_sectors / delete_missing_sectors: matricize/unmatricize no longer needs to pad with multiplicity-0 sectors to force matching codomain/domain
  • Bumps to v0.9 since probably should be considered breaking

@lkdvos lkdvos changed the title Ld nonsquare Non-square FusedGradedMatrix May 4, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 4, 2026

Codecov Report

❌ Patch coverage is 80.14706% with 54 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.52%. Comparing base (e9d7e0d) to head (5857ac6).

Files with missing lines Patch % Lines
src/fusedgradedvector.jl 23.52% 39 Missing ⚠️
src/fusedgradedmatrix.jl 88.42% 11 Missing ⚠️
src/matrixalgebrakit.jl 96.61% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #167      +/-   ##
==========================================
- Coverage   82.00%   81.52%   -0.49%     
==========================================
  Files          22       22              
  Lines        1523     1597      +74     
==========================================
+ Hits         1249     1302      +53     
- Misses        274      295      +21     
Flag Coverage Δ
docs 0.00% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ITensor ITensor deleted a comment from ITensorBot May 4, 2026
Comment thread examples/Project.toml
@lkdvos
Copy link
Copy Markdown
Contributor Author

lkdvos commented May 4, 2026

It also looks like the documenter workflow is not correctly instantiating the environment somehow

@mtfishman
Copy link
Copy Markdown
Member

It also looks like the documenter workflow is not correctly instantiating the environment somehow

Hmm I've been making a lot of changes to workflows, maybe something broke, I'll look into it...

@lkdvos
Copy link
Copy Markdown
Contributor Author

lkdvos commented May 4, 2026

Hmmm, it might have also just been the compat things, it seems to have sorted itself out now?

Here are the ones that failed:

https://github.com/ITensor/GradedArrays.jl/actions/runs/25340068435
https://github.com/ITensor/GradedArrays.jl/actions/runs/25340160415

I think I got mostly confused because the failing resolver didn't cancel the remainder of the workflow

@mtfishman mtfishman merged commit 5d95ff0 into main May 6, 2026
16 of 18 checks passed
@mtfishman mtfishman deleted the ld-nonsquare branch May 6, 2026 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants