IntegrationTest: skip aggregate gate on draft PRs#109
Merged
Conversation
The matrix-driven `integration-test` job already skips on `draft + run-on-draft=false`, but the aggregate `gate` job ran unconditionally (`if: always()`) and its script's `RESULT=skipped` + non-empty `pkgs` branch — designed for the unexpected all-skipped case — fired with `Integration matrix unexpectedly all skipped`, turning the `IntegrationTest` check Red on every draft PR. Mirror the matrix-leg's draft predicate on the gate so the gate is itself Skipped on draft + `run-on-draft=false`. The check appears as Skipped (not Failure) on the PR view, which matches the intent of the draft skip — no signal expected, no error reported. Non-draft PRs are unaffected. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IntegrationTestaggregate gate inherit the matrix-leg's draft predicate so it appears as Skipped (not Failure) on draft PRs withrun-on-draft: false(the default).README.md's "Draft PR behavior" section to reflect this.The matrix-driven
integration-testjob skips whendraft && !run-on-draft. The gate job ran withif: always()and its script's "matrix all-skipped" branch — designed for the unexpected all-skipped case — fired withIntegration matrix unexpectedly all skipped, turning theIntegrationTestcheck Red on every draft PR. Non-draft andrun-on-draft: truepaths are unchanged; the unexpected-all-skipped error path remains for genuine matrix scheduling flukes.