Return falsy values from failed authentication, per Ninja expectations#1243
Closed
brianhelba wants to merge 2864 commits intomasterfrom
Closed
Return falsy values from failed authentication, per Ninja expectations#1243brianhelba wants to merge 2864 commits intomasterfrom
brianhelba wants to merge 2864 commits intomasterfrom
Conversation
Properly format the count on the users page
Remove django-json-widget
Add ORM optimizations for bulk metadata application
…-created-m2m Add through table for collection image relationships
Use a streaming response for zipstreamer metadata files
This also adds some sentry instrumentation to more accurately classify time spent parsing.
Increase the size of the DSL parsing cache
Apply collection description styles to DOI pages
Stop storing Accession.blob_name
Stop recreating metadata files on blob deletion
Ensure that default attribution is only applied during publish
Add a trailing slash to a js url
…ounts Remove the lesion and patient counts from the DOI detail page
Allow specifying which DOIs to update on datacite
Move cohort publishing code to a publish service
This adds a PublishRequest model for tracking the accessions and where/how they should be published. This makes it easier to separate the publishing process into multiple steps: publish and optionally unembargo. This will be necessary going forward as the unembargo process is going to get more complicated with the introduction of sponsored bucket storage and IPTC tagging.
Fix uv lockfile
…tion Use orjson for zip descriptor listing
Ensure cachalot entries expire immediately in development
…edia-url Stop depending on the storage media url in test
This resolves a bunch of circular import issues, which required function-local imports.
Apply changes from Resonant v0.33
Follow on from #1273.
Invert the `Collection`-`Doi` relationship and use `DoiFactory` directly in tests
Member
|
@brianhelba PTAL at the commit I put on. Ninja says it wants something that's convertible to boolean (https://django-ninja.dev/guides/authentication/#custom-function), not boolean. We depend on the token value in the view so this was failing tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.