Conversation
tevincent
force-pushed
the
ktlint
branch
20 times, most recently
from
85bcc20 to
f377a2c
Compare
tevincent
force-pushed
the
ktlint
branch
2 times, most recently
from
dad4577 to
6da219d
Compare
# Conflicts: # build.gradle.kts
# Conflicts: # .editorconfig # .github/workflows/android.yml # build.gradle.kts
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Kotlin formatting/lint enforcement via ktlint, along with baselines to avoid fixing all existing violations at once, and wires a ktlint check into GitHub Actions CI.
Changes:
- Register and apply the
org.jlleitschuh.gradle.ktlintGradle plugin and configure ktlint options/baseline. - Add ktlint baseline files (root +
app) to suppress existing violations. - Add a dedicated CI job intended to run ktlint, plus a root
.editorconfigwith ktlint rule toggles.
Reviewed changes
Copilot reviewed 5 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
gradle/libs.versions.toml |
Adds ktlint plugin alias to the version catalog. |
config/ktlint/baseline.xml |
Adds a root ktlint baseline file. |
build.gradle.kts |
Applies/configures ktlint Gradle plugin and points to baseline. |
app/config/ktlint/baseline.xml |
Adds an app-module ktlint baseline with existing violations. |
.github/workflows/android.yml |
Adds a new CI job to run ktlint. |
.editorconfig |
Introduces ktlint configuration and disables selected rules. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces Kotlin Ktlint code style enforcement to the project, including configuration files, a GitHub Actions workflow for automated lint checking, and updates to dependencies. The main goal is to standardize code formatting and ensure linting is part of the CI process.
Ktlint integration and configuration:
.editorconfigfile with Ktlint-specific rules and customizations for Kotlin files, including disabling several standard rules and setting a maximum line length.config/ktlint/baseline.xmlfile to suppress existing Ktlint violations, enabling incremental adoption of linting.CI/CD pipeline updates:
.github/workflows/android.ymlto add a newktlintjob that runs on every pull request, ensuring code style checks are automated in CI.Dependency management:
gradle/libs.versions.tomlfor consistent linting across environments.Submodule update:
Coresubmodule to a new commit, possibly to align with the new linting standards or other upstream changes.depends on Infomaniak/android-core#484
depens on Infomaniak/android-core#490