fix: Wrong folder issue#2048
Open
NicolasBourdin88 wants to merge 5 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes incorrect “current folder” state propagation by improving how the currently-loaded folder is refreshed/cancelled and by making the Add File bottom sheet react to folder changes instead of snapshotting once.
Changes:
- Update
MainViewModel.loadCurrentFolderto cancel/replace in-flight current-folder loads. - Adjust
SharedWithMeFragmentto load the correct folder ID for root vs non-root shared views. - Rework
AddFileBottomSheetDialogto observe current-folder LiveData and update UI accordingly.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| app/src/main/java/com/infomaniak/drive/ui/menu/SharedWithMeFragment.kt | Loads current folder using SharedWithMe root ID when applicable. |
| app/src/main/java/com/infomaniak/drive/ui/MainViewModel.kt | Refactors current-folder loading/cancellation behavior. |
| app/src/main/java/com/infomaniak/drive/ui/addFiles/AddFileBottomSheetDialog.kt | Observes current folder to avoid using a stale folder when opening the bottom sheet. |
NicolasBourdin88
force-pushed
the
fix-wrong-folder-issue
branch
from
8775274 to
c8925b6
Compare
NicolasBourdin88
force-pushed
the
fix-wrong-folder-issue
branch
from
c8925b6 to
0db4838
Compare
NicolasBourdin88
force-pushed
the
fix-wrong-folder-issue
branch
from
ca0ea0c to
69baf8b
Compare
NicolasBourdin88
force-pushed
the
fix-wrong-folder-issue
branch
from
69baf8b to
ec8ee1b
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.