fix: Delete local folder when API returns a success#2967
Open
Elouan1411 wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR aims to keep the local mailbox content cache consistent with the server by deleting the locally cached folder immediately after the folder deletion API call succeeds.
Changes:
- In
MainViewModel, delete the local folder from the Realm cache when the API delete call succeeds (before refreshing folders). - In
FolderController, add a newdeleteFolder(id, mailbox)helper to remove a folder from the local mailbox-content Realm.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| app/src/main/java/com/infomaniak/mail/ui/MainViewModel.kt | Calls local cache deletion on successful folder deletion API response, then refreshes folders. |
| app/src/main/java/com/infomaniak/mail/data/cache/mailboxContent/FolderController.kt | Introduces a local deleteFolder method that deletes a folder from the mailbox-content Realm. |
tevincent
requested changes
Jul 2, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.