BUG: Add VTKPolyDataMeshIO FIELD data support (forward-port of #4859)#6188
Merged
thewtex merged 1 commit intoInsightSoftwareConsortium:mainfrom May 8, 2026
Merged
Conversation
Closed
github-actions
Bot
added
type:Bug
Member
Author
|
@greptileai review this draft before I make it official |
This comment was marked as resolved.
This comment was marked as resolved.
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
3 tasks
Member
|
@hjmjohnson thanks! Have you verified that the result can be read by a VTK-based reader, e.g. Slicer? |
Member
Author
|
@thewtex both files read fine by Slicer; visually identical.
Same surface: 326 points, 648 polygons, same per-cell scalar. |
Member
Author
|
@thewtex merge if approved. |
Read VTK legacy FIELD data entries in POINT_DATA and CELL_DATA
sections as VariableLengthVector when the tuple count matches the
point/cell count. Read{Point,Cell}DataBufferAs{ASCII,BINARY} now
consume the array-header line after the FIELD keyword (without
this fix the header was parsed as data and the test failed).
Only the first field-data array per section is used. Adds gourd.vtk
fixture exercising the path. Forward-port of InsightSoftwareConsortium#4859.
Co-Authored-By: Matt McCormick <matt@mmmccormick.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forward-port of #4859 from
release-5.4tomain, with the bug that madeitkMeshFileReadWriteTestFieldfail now fixed. Adds reading of VTK legacyFIELD FieldData Nblocks insidePOINT_DATA/CELL_DATAsections of.vtkPolyData files; data lands asVariableLengthVectorpixels. Closes #4859.The bug fix
#4859 set
m_PointPixelType=VARIABLELENGTHVECTORinReadMeshInformationbut didn't teachRead{Point,Cell}DataBufferAs{ASCII,BINARY}how to parse the FIELD layout. The extra array-header line:was consumed as the first data values, producing garbage. The fix adds a
find("FIELD")branch alongside the existingSCALARSbranch in all four buffer readers to consume the array-header line first.Closes #4859.