Skip to content

Update (fix) GitHub action#138

Merged
alastairreid merged 5 commits intomasterfrom
areid/github-action
Apr 27, 2026
Merged

Update (fix) GitHub action#138
alastairreid merged 5 commits intomasterfrom
areid/github-action

Conversation

@alastairreid
Copy link
Copy Markdown

@alastairreid alastairreid commented Apr 23, 2026

Updates the github action that was failing because of problems in the opam lock file.
While doing this, I renamed the dune files from asl-interpreter to isa-tools

In the process of doing this, I also

  • updated the compiler to 5.4.1 to overcome some issues in 'make doc'.
  • disabled treatment of warnings as errors in 'make doc' because it was reporting a warning involving the Menhir parser generator and I couldn't see any way to fix or suppress that warning.

@alastairreid alastairreid force-pushed the areid/github-action branch 2 times, most recently from aeb3852 to 88d184b Compare April 24, 2026 11:20
ocamldoc refused to build the parser because of something that Menhir
was doing. Moving forward to 5.4 fixes the problem
The latest version of odoc insists on generating the following warning

File ../../../libISA/.libISA.objs/byte/libISA.odoc:
Warning: While resolving the expansion of include at File libISA/isa_parser.mli, line 134, character 2
Hidden constructors in type 'LibISA.Isa_parser.MenhirInterpreter.element'

This warning relates to code generated by the menhir parser generator and there
seems to be no way to prevent the warning from being generated.

So I am reluctantly disabling the 'warnings are fatal' setting so that we can
avoid what I consider to be a odoc/menhir bug.
@alastairreid alastairreid merged commit f613396 into master Apr 27, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants