Update (fix) GitHub action#138
Merged
alastairreid merged 5 commits intomasterfrom Apr 27, 2026
Merged
Conversation
aeb3852 to
88d184b
Compare
ocamldoc refused to build the parser because of something that Menhir was doing. Moving forward to 5.4 fixes the problem
The latest version of odoc insists on generating the following warning File ../../../libISA/.libISA.objs/byte/libISA.odoc: Warning: While resolving the expansion of include at File libISA/isa_parser.mli, line 134, character 2 Hidden constructors in type 'LibISA.Isa_parser.MenhirInterpreter.element' This warning relates to code generated by the menhir parser generator and there seems to be no way to prevent the warning from being generated. So I am reluctantly disabling the 'warnings are fatal' setting so that we can avoid what I consider to be a odoc/menhir bug.
88d184b to
d3b7eea
Compare
nikolaykosarev
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the github action that was failing because of problems in the opam lock file.
While doing this, I renamed the dune files from asl-interpreter to isa-tools
In the process of doing this, I also