Improve lexing parsing error messages#140
Merged
alastairreid merged 4 commits intomasterfrom Apr 30, 2026
Merged
Conversation
alastairreid
changed the title
nikolaykosarev
approved these changes
Apr 28, 2026
Also, when there is no filename (e.g., because the input comes
from the terminal), print
"line 1"
instead of
"file line 1"
Fixes #119
This was a really bad issue because it meant that you could be in the middle of an interactive session, type an incorrect lexeme, and the session would be aborted. The fix is easy: report it as a parsing error Fixes #82
alastairreid
force-pushed
the
areid/fix-lexing-parsing-error-messages
branch
from
7ba96c5 to
b8bdddc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #119.
Fixes #82.