Clean up dead code guarded by outdated oneMKL and DPC++ version checks#2999
Merged
Conversation
antonwolfy
requested review from
ndgrigorian and
vlad-perevezentsev
as code owners
July 13, 2026 10:50
Contributor
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
Contributor
|
Array API standard conformance tests for dpnp=0.21.0dev3=py313h509198e_4 ran successfully. |
vlad-perevezentsev
approved these changes
Jul 15, 2026
vlad-perevezentsev
left a comment
vlad-perevezentsev
left a comment
Contributor
There was a problem hiding this comment.
LGTM
Thank you @antonwolfy
github-actions Bot
added a commit
that referenced
this pull request
Jul 15, 2026
#2999) Since the build and runtime minimum was raised to **oneMKL / DPC++ compiler 2026.0** (`conda-recipe/meta.yaml`), several preprocessor and version guards now select a fixed branch on every supported configuration. This PR removes the resulting dead code and replaces version comparisons with the condition they actually encode. 8a9b1a3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the build and runtime minimum was raised to oneMKL / DPC++ compiler 2026.0 (
conda-recipe/meta.yaml), several preprocessor and version guards now select a fixed branch on every supported configuration. This PR removes the resulting dead code and replaces version comparisons with the condition they actually encode.