Skip to content

Conversation

@johnalotoski
Copy link
Contributor

Description

  • Bumps iohkNix for new tracing system tuning seen in iohk-nix-pr-608, also related to cardano-node-pr-6388
  • Adjusts local reference configuration to align with new iohkNix reference cfg changes

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • CI passes. See note on CI. The following CI checks are required:
  • Self-reviewed the diff

Copilot AI review requested due to automatic review settings January 6, 2026 00:34
@johnalotoski johnalotoski requested a review from a team as a code owner January 6, 2026 00:34
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the iohk-nix dependency to incorporate new tracing system tuning and adjusts local configuration files to align with the reference configuration changes from iohk-nix PR #608.

Key Changes:

  • Updates iohk-nix dependency to the coot/new-tracing-system branch
  • Removes the TraceOptionPeerFrequency configuration option across all config files
  • Increases verbosity by changing certain trace severities from Silence to Info for better alignment with legacy tracing behavior
  • Removes the now-unnecessary Net.ConnectionManager.Remote.ConnectionManagerCounters configuration

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
flake.nix Updates iohk-nix input to reference the new-tracing-system branch
flake.lock Locks the iohk-nix dependency to the specific commit from the new branch
configuration/cardano/testnet-template-config.json Adjusts tracing configuration to align with new system (removes peer frequency option, updates severity levels)
configuration/cardano/mainnet-config.yaml Applies same tracing configuration adjustments as testnet template
configuration/cardano/mainnet-config.json Applies same tracing configuration adjustments in JSON format

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

@snarlysodboxer snarlysodboxer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johnalotoski johnalotoski added this pull request to the merge queue Jan 7, 2026
Merged via the queue into master with commit 7dd411c Jan 7, 2026
26 checks passed
@johnalotoski johnalotoski deleted the jl/new-tracing-cfg branch January 7, 2026 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants