[MOB-11549] creates IterableEmbeddedMessageMetadata class#654
Merged
evantk91 merged 3 commits intoJun 10, 2025
Merged
Conversation
|
❌ 2 blocking issues (3 total)
This is from Qlty Cloud, the successor to Code Climate Quality. Learn more. |
![qlty-cloud-legacy[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| @@ -0,0 +1,58 @@ | |||
| import { IterableEmbeddedMessageMetadata } from '../embedded/classes/IterableEmbeddedMessageMetadata'; | |||
There was a problem hiding this comment.
| @@ -0,0 +1,65 @@ | |||
| /** | |||
There was a problem hiding this comment.
Comment on lines
+22
to
+26
| constructor( | ||
| messageId: string, | ||
| placementId: number, | ||
| campaignId: number | undefined, | ||
| isProof: boolean = false |
lposen
approved these changes
Jun 9, 2025
Contributor
lposen
left a comment
lposen
left a comment
There was a problem hiding this comment.
Looks good. Please just address the commenting item.
| * An interface defining the dictionary object containing the metadata properties for an embedded message. | ||
| */ | ||
| export interface EmbeddedMessageMetadataDict { | ||
| messageId: string; |
Contributor
There was a problem hiding this comment.
Please comment what each of the props are
| * | ||
| * @returns A new instance of `IterableEmbeddedMessageMetadata` with the provided properties. | ||
| */ | ||
| static fromDict( |
Contributor
There was a problem hiding this comment.
Side rant:
Personally, I really don't like the fromDict functions. It's just not a typical javascript pattern, so my spidey sense goes off when I see it (though I can't exactly figure out why). To me, this should all just be handled in a constructor.
That being said, we use fromDict in so many places that we should follow the established pattern and keep it.
Contributor
Author
There was a problem hiding this comment.
Hm yeah maybe that can be a future improvement.
Contributor
Author
There was a problem hiding this comment.
export class IterableEmbeddedMessageMetadata {
readonly messageId: string;
readonly placementId: number;
readonly campaignId?: number;
readonly isProof: boolean;
constructor({
messageId,
placementId,
campaignId,
isProof = false
}: EmbeddedMessageMetadataDict) {
if (!messageId || !placementId) {
throw new Error('messageId and placementId are required');
}
this.messageId = messageId;
this.placementId = placementId;
this.campaignId = campaignId;
this.isProof = isProof;
}
}
// Usage:
new IterableEmbeddedMessageMetadata({
messageId: 'msg123',
placementId: 456,
campaignId: 789,
isProof: false
});
Base automatically changed from
evan/MOB-11561-enableEmbeddedMessaging-flag
to
evan/feature/embedded
June 9, 2025 21:36
| @@ -0,0 +1,58 @@ | |||
| import { IterableEmbeddedMessageMetadata } from '../embedded/classes/IterableEmbeddedMessageMetadata'; | |||
There was a problem hiding this comment.
| @@ -0,0 +1,65 @@ | |||
| /** | |||
There was a problem hiding this comment.
Comment on lines
+22
to
+26
| constructor( | ||
| messageId: string, | ||
| placementId: number, | ||
| campaignId: number | undefined, | ||
| isProof: boolean = false |
…edded-metadata-class
| @@ -0,0 +1,58 @@ | |||
| import { IterableEmbeddedMessageMetadata } from '../embedded/classes/IterableEmbeddedMessageMetadata'; | |||
There was a problem hiding this comment.
| @@ -0,0 +1,65 @@ | |||
| /** | |||
There was a problem hiding this comment.
Comment on lines
+22
to
+26
| constructor( | ||
| messageId: string, | ||
| placementId: number, | ||
| campaignId: number | undefined, | ||
| isProof: boolean = false |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔹 JIRA Ticket(s) if any
✏️ Description