Add unit tests for amRviz package (utilities, data loading, plots, UI, network, annotations)#16
Open
eboyer221 wants to merge 3 commits into
Open
Add unit tests for amRviz package (utilities, data loading, plots, UI, network, annotations)#16eboyer221 wants to merge 3 commits into
eboyer221 wants to merge 3 commits into
Conversation
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds ~150 unit tests across 13 test files.
amRshiny→amRvizpackage references in test files were updated.makeFeatureImportTable adds hyperlinks for COG column) was adjusted from usingCOG_nametoCOG, matching where PR Package name change from amRshiny to amRviz + New Visualizations #20 actually attaches the NCBI link.Test plan
You should see output ending with approximately [ FAIL 0 | WARN 3 | SKIP 1 | PASS 150 ]. The 1 skip is the interactive-only app launch test. The 3 warnings are pre-existing tidyselect deprecations in PR #20's implementation code (in enrich_with_annotations and makeCogBarChart), not caused by these tests.
Coverage
Utility & helpers:
normalize_species,getHoldoutsDrugChoices.normalize_results_root,.read_parquet_safeData loading:
loadMLResults,loadTopFeat,listAmRmlSpeciesFolders,get_metadata_path,loadDrugClassMapAnnotation loading and enrichment:
load_feature_annotations,enrich_with_annotations,load_feature_name_mapPlot generation:
makeDatAvailabilityPlot,makeTimeSeriesAMRPlot,makeHostIsolatePlot,makeIsolationSourcesPlot,makeModelPerformancePlot,makeFeatureImportancePlot,makeCrossModelPerformancePlot,makeMetadataSankey,makeCogBarChart,makeDrugFeatureNetwork,makeFeatureEgoNetwork,makeCrossModelRidgePlotTable formatting:
makeFeatureImportTableUI modules:
queryDataUI,metadataUI,modelPerfUI,featureImportanceUI,crossModelComparisonUI,networkUI,launchAMRDashboard