Removed unused DuckDB code path, dead helpers, and 16 MB unused data#25
Open
eboyer221 wants to merge 1 commit into
Open
Removed unused DuckDB code path, dead helpers, and 16 MB unused data#25eboyer221 wants to merge 1 commit into
eboyer221 wants to merge 1 commit into
Conversation
| drug_class_map_df <- readr::read_tsv( | ||
| here(drug_class_map_fp), | ||
| show_col_types = FALSE | ||
| ) %>% |
Contributor
There was a problem hiding this comment.
Just a suggestion, we can switch to the base R pipe (|>) throughout, and only retain %>% where it's explicitly required.
Contributor
Author
There was a problem hiding this comment.
That's a good point @AbhirupaGhosh. I could get rid of magrittr from our Imports if that switches. I assume that would be better for Bioconductor, since they don't want unnecessary dependencies?
@amcim @jananiravi - Should I do a separate follow-up PR that migrates the package to |> and drops magrittr from Imports?
Contributor
There was a problem hiding this comment.
Yes it would definitely be worth making that conversion to |> and it will be a quick PR to review
AbhirupaGhosh
approved these changes
May 28, 2026
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PR removes unused data files and dead code that is no longer necessary for amRviz functionality.
The dashboard no longer uses
inst/extdata/amr_filtered_tbls.db(16MB), it was superseded by the parquet-based loading path that landed in previous PRs. This PR removes that file as well as functions that are no longer needed in order to free up space and clean the codebase.Removed
Functions (all in
R/utils.R, all with zero references outside their own definition — verified by grep acrossR/,inst/,tests/):getAllFilteredData— old DuckDB writer; populated the.dbfrom per-species DuckDBs.loadAMRMetadata— old DuckDB reader; the dashboard now usesloadMLResults/loadTopFeat/get_metadata_pathreading parquet files instead.getTopFeatures— pre-parquet loader for top-features TSVs that wrote into ashinyapp/data/path that doesn't exist in the package.combinePerformanceMetrics— same pre-parquet pipeline; wrote to the same non-existentshinyapp/data/paths.getAmrDrugsbug_choices- hardcoded ESKAPE lookup. The dashboard now derives bug choices dynamically from loaded data (this was finalized in PR Fix install + dashboard rendering with bundled demo data #18).Data:
inst/extdata/amr_filtered_tbls.db(16MB). Only the deleted functions touched it.Imports:
DBIandduckdbremoved fromDESCRIPTIONand the matching@importFromroxygen tags inR/utils.R. The only callers ofDBI::*andduckdb::*were inside the deleted functions, so the package no longer depends on either.README: removed the
amr_filtered_tbls.dbbullet under "Data requirements" - that line was already inaccurate since the dashboard hasn't read from the DB in some time.inst/extdata/now contains only the per-species parquet files and the small TSV/CSV lookups (≪1MB total).Test plan
devtools::load_all()thenlaunchAMRDashboard()- dashboard builds and every tab loads with no missing-function errors.devtools::check()- no errors and no test failures introduced.