feat(port): mute on window focus loss#237
Open
Zorkats wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
One independent behavior, off-by-default-friendly and independently toggled from Settings > Audio > Focus Behavior:
gSettings.FocusControl.MuteOnFocusLossMute: when the window loses focus and the CVar is enabled,
gSettings.Audio.MasterVolumeis saved and set to0.0f. On refocus, the saved value is restored. Volume-save state uses a sentinel of-1.0fso a double focus-loss doesn't corrupt the saved value.Implementation
port/focus.h/port/focus.cpp—ssb64::RegisterFocusListener()registers aWindowFocusEventlistener viaREGISTER_LISTENER. No global listener object; the listener ID is fire-and-forget (unregistered on shutdown via the event system teardown).port/hooks/Events.h— adds#include "ship/events/WindowEvents.h"soWindowFocusEventis available to all port TUs that includeEvents.h.port/hooks/Events.cpp— addsREGISTER_EVENT(WindowFocusEvent)toPortRegisterEvents().port/port.cpp— callsssb64::RegisterFocusListener()immediately afterPortRegisterEvents().port/gui/PortMenu.cpp— adds "Focus Behavior" separator and one checkbox in the Audio sidebar, after the voice volume slider.focus.cppis picked up byfile(GLOB_RECURSE SSB64_SRC_PORT "port/*.cpp" ...)inCMakeLists.txt; no CMake edit was needed.Depends on PR#7 of libultraship.
Test plan