Add ESM support to WASM package#1000
Closed
christopher-buss wants to merge 2 commits intoJohnnyMorganz:mainfrom
Closed
Add ESM support to WASM package#1000christopher-buss wants to merge 2 commits intoJohnnyMorganz:mainfrom
christopher-buss wants to merge 2 commits intoJohnnyMorganz:mainfrom
Conversation
- Add dual package support (ESM and CommonJS) - Update exports configuration for proper module resolution - Add rollup build process for generating .cjs and .mjs files - Add type definitions for both module formats - Update build script to generate both module formats This enables the package to be used in both ESM and CommonJS environments.
- Remove bundler-specific JS files (stylua_lib_bundler.js, stylua_lib_bundler_wbg.cjs) - Remove extra type definition files (.d.cts, .d.mts, bundler.d.ts) - Clean up package.json files array and remove browser field - Update sideEffects to include the actual generated files The simpler exports configuration handles all environments correctly without needing separate bundler files or multiple type definitions.
Owner
|
I think #1060 should solve this problem |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds proper ES Module (ESM) support to the WASM package while maintaining full backwards compatibility with CommonJS. The package now works seamlessly in both module systems without requiring any changes from existing users.
Changes
.cjs(CommonJS) and.mjs(ESM) files from a single sourcerequire/import) that work across all environmentsTechnical Details
The implementation uses Rollup to transform a single ESM source file into both CommonJS and ESM outputs. This ensures consistency between the two formats and reduces maintenance burden. The WASM module is automatically initialized when imported, making the API identical for both module systems.