Skip to content

draft MvNormal#122

Draft
cscherrer wants to merge 31 commits into
masterfrom
cs-mvnormal
Draft

draft MvNormal#122
cscherrer wants to merge 31 commits into
masterfrom
cs-mvnormal

Conversation

@cscherrer

Copy link
Copy Markdown
Collaborator

No description provided.

@github-actions

Copy link
Copy Markdown
Contributor
Package name latest stable
Mitosis.jl
Soss.jl

@github-actions

Copy link
Copy Markdown
Contributor
Package name latest stable
Mitosis.jl
Soss.jl

@mschauer

Copy link
Copy Markdown
Member

What do you think of going the way of GaussianDistributions.jl and have one object for 1d and nd Gaussians?

@github-actions

Copy link
Copy Markdown
Contributor
Package name latest stable
Mitosis.jl
Soss.jl

@cscherrer

Copy link
Copy Markdown
Collaborator Author

What do you think of going the way of GaussianDistributions.jl and have one object for 1d and nd Gaussians?

It's an interesting idea, my only concerns would be

  1. The types are different - scalar vs (possibly 1d) vector
  2. It could be a little confusing coming from Distributions.

Then again, I've strayed a little from Distributions's naming already; TDist is an awful name IMO, so in MeasureTheory it's StudentT

@github-actions

Copy link
Copy Markdown
Contributor
Package name latest stable
Mitosis.jl
Soss.jl

@github-actions

Copy link
Copy Markdown
Contributor
Package name latest stable
Mitosis.jl
Soss.jl

@github-actions

Copy link
Copy Markdown
Contributor
Package name latest stable
Mitosis.jl
Soss.jl

@github-actions

Copy link
Copy Markdown
Contributor
Package name latest stable
Mitosis.jl
Soss.jl

@github-actions

github-actions Bot commented Aug 3, 2021

Copy link
Copy Markdown
Contributor
Package name latest stable
Mitosis.jl
Soss.jl

@github-actions

github-actions Bot commented Aug 3, 2021

Copy link
Copy Markdown
Contributor
Package name latest stable
Mitosis.jl
Soss.jl

@github-actions

github-actions Bot commented Aug 4, 2021

Copy link
Copy Markdown
Contributor
Package name latest stable
Mitosis.jl
Soss.jl

@github-actions

github-actions Bot commented Aug 4, 2021

Copy link
Copy Markdown
Contributor
Package name latest stable
Mitosis.jl
Soss.jl

@github-actions

github-actions Bot commented Aug 4, 2021

Copy link
Copy Markdown
Contributor
Package name latest stable
Mitosis.jl
Soss.jl

@codecov

codecov Bot commented Aug 5, 2021

Copy link
Copy Markdown

Codecov Report

Merging #122 (6e1fca0) into master (8a2c551) will increase coverage by 2.49%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #122      +/-   ##
==========================================
+ Coverage   33.96%   36.46%   +2.49%     
==========================================
  Files          50       45       -5     
  Lines         998      883     -115     
==========================================
- Hits          339      322      -17     
+ Misses        659      561      -98     
Impacted Files Coverage Δ
src/MeasureTheory.jl 50.00% <ø> (ø)
src/utils.jl 31.25% <ø> (ø)
src/macros.jl 58.55% <0.00%> (-0.38%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a2c551...6e1fca0. Read the comment docs.

@github-actions

github-actions Bot commented Aug 5, 2021

Copy link
Copy Markdown
Contributor
Package name latest stable
Mitosis.jl
Soss.jl

@github-actions

github-actions Bot commented Aug 6, 2021

Copy link
Copy Markdown
Contributor
Package name latest stable
Mitosis.jl
Soss.jl

@github-actions

github-actions Bot commented Aug 6, 2021

Copy link
Copy Markdown
Contributor
Package name latest stable
Mitosis.jl
Soss.jl

@github-actions

github-actions Bot commented Aug 6, 2021

Copy link
Copy Markdown
Contributor
Package name latest stable
Mitosis.jl
Soss.jl

@github-actions

github-actions Bot commented Aug 6, 2021

Copy link
Copy Markdown
Contributor
Package name latest stable
Mitosis.jl
Soss.jl

@github-actions

github-actions Bot commented Aug 6, 2021

Copy link
Copy Markdown
Contributor
Package name latest stable
Mitosis.jl
Soss.jl

@github-actions

github-actions Bot commented Aug 6, 2021

Copy link
Copy Markdown
Contributor
Package name latest stable
Mitosis.jl
Soss.jl

@github-actions

github-actions Bot commented Aug 6, 2021

Copy link
Copy Markdown
Contributor
Package name latest stable
Mitosis.jl
Soss.jl

@github-actions

github-actions Bot commented Aug 6, 2021

Copy link
Copy Markdown
Contributor
Package name latest stable
Mitosis.jl
Soss.jl

@github-actions

github-actions Bot commented Aug 6, 2021

Copy link
Copy Markdown
Contributor
Package name latest stable
Mitosis.jl
Soss.jl

@github-actions

github-actions Bot commented Aug 8, 2021

Copy link
Copy Markdown
Contributor
Package name latest stable
Mitosis.jl
Soss.jl

@github-actions

github-actions Bot commented Aug 8, 2021

Copy link
Copy Markdown
Contributor
Package name latest stable
Mitosis.jl
Soss.jl

@github-actions

github-actions Bot commented Aug 9, 2021

Copy link
Copy Markdown
Contributor
Package name latest stable
Mitosis.jl
Soss.jl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants