This repository was archived by the owner on Jan 6, 2022. It is now read-only.
Fix for lag when recoloring blocks#529
Open
Jake-Rich wants to merge 1 commit intoKeenSoftwareHouse:masterfrom
Jake-Rich:ColorChangeLagFix
Open
Fix for lag when recoloring blocks#529Jake-Rich wants to merge 1 commit intoKeenSoftwareHouse:masterfrom Jake-Rich:ColorChangeLagFix
Jake-Rich wants to merge 1 commit intoKeenSoftwareHouse:masterfrom
Jake-Rich:ColorChangeLagFix
Conversation
|
I've known the physics re-calculations to cause some semi-stable Multiplayer builds to explode just by giving them a lick of paint, so stopping THAT would be nice. |
Author
|
New to github, and accidently un-published the wrong branch, causing it to be closed. Now reopened. Also added a video to help show the bug. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When recoloring blocks on a big surface, sim-speed would drop and fps would drop (even though it doesn't in debug view).
It was marking the blocks as "dirty" which would cause the Havok physics shape to be recalculated every time blocks were being painted, however the physics shape would never change when the color changed.
You can see performance differences in this screenshot. http://imgur.com/xXWBOnb or in this youtube video. https://youtu.be/ytw4v7cd-kg